After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660650 - ShellApp: Junk last_used_time
ShellApp: Junk last_used_time
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-10-01 20:33 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2011-10-24 20:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ShellApp: Junk last_used_time (3.55 KB, patch)
2011-10-01 20:33 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2011-10-01 20:33:18 UTC 
This fixes a lot of tiny bugs with window stacking for me:

1. Opening two windows in the same application, and switching to one of them
   and closing it will cause the application to be second in place, because
   mutter updates the LUT when you activate it. Quite surprising.

2. Various applications not ordering correctly in the alt-tab. Totem, for
   some strange reason, has been one of these applications.

3. Closing one window of an application won't cause a restack and all the
   windows of an application to be lowered.
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-10-01 20:33:20 UTC 
Created attachment 197981 [details] [review]
ShellApp: Junk last_used_time

Instead of saving the last_used_time per-app, grab the maximum time for all
windows. The logic is less hard to keep track of, and it solves some edge
case issues where windows that no longer exist update the user time, even
if none of the other windows have been used recently.
Comment 2 Dan Winship 2011-10-01 21:15:16 UTC 
is this the same as bug 645026?
Comment 3 Jasper St. Pierre (not reading bugmail) 2011-10-01 23:12:13 UTC 
(In reply to comment #2)
> is this the same as bug 645026?

It's a solution to that bug, but also some others that we wouldn't be able to deal with without special-cased code, like the first of the examples I give.

I'm not sure how we should classify this bug.
Comment 4 Colin Walters 2011-10-24 20:18:07 UTC 
Review of attachment 197981 [details] [review]:

This looks safe to me.
Comment 5 Jasper St. Pierre (not reading bugmail) 2011-10-24 20:22:58 UTC 
Attachment 197981 [details] pushed as 95de48e - ShellApp: Junk last_used_time