After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660628 - Cheese should use the new dark gtktheme
Cheese should use the new dark gtktheme
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
git master
Other Linux
: Normal enhancement
: 3.0
Assigned To: David King
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-10-01 13:01 UTC by Bjørn Lie
Modified: 2011-10-16 05:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
prefer a dark GTK+ theme (866 bytes, patch)
2011-10-04 08:54 UTC, David King
committed Details | Review
cheese with normal theme variant (506.28 KB, image/png)
2011-10-11 15:29 UTC, David King
  Details
cheese with dark theme variant (518.83 KB, image/png)
2011-10-11 15:30 UTC, David King
  Details

Description Bjørn Lie 2011-10-01 13:01:49 UTC
Keeping in line with other photo/video apps using the new dark theme ( like totem and eog) Cheese should by default.
Comment 1 David King 2011-10-04 08:54:50 UTC
Created attachment 198202 [details] [review]
prefer a dark GTK+ theme

The attached patch sets the GtkSetting "gtk-application-prefer-dark-theme":

http://developer.gnome.org/gtk3/stable/GtkSettings.html#GtkSettings--gtk-application-prefer-dark-theme

to true, which enables the dark variant of the current theme, if it is available.
Comment 2 Bjørn Lie 2011-10-06 15:31:49 UTC
Hi and thanks for the patch.

In order to make cheese build with 3.2.0 tarball I had to get the cheese-common.vapi from git and cp that into my build after patch.

Buildlog available here if you like to take a look.

https://build.opensuse.org/package/rawlog?arch=x86_64&package=cheese&project=home%3AZaitor%3Abranches%3AGNOME%3AFactory&repository=openSUSE_Factory

Specfile here

https://build.opensuse.org/package/files?package=cheese&project=home%3AZaitor%3Abranches%3AGNOME%3AFactory
Comment 3 Vincent Untz 2011-10-11 07:01:24 UTC
David: is this patch going to be committed upstream? I wouldn't want to push it in openSUSE if upstream doesn't move to this in the end :-)
Comment 4 David King 2011-10-11 07:53:21 UTC
Vincent: I asked about this on cheese-list:

http://mail.gnome.org/archives/cheese-list/2011-October/msg00000.html
Comment 5 David King 2011-10-11 15:29:51 UTC
Created attachment 198793 [details]
cheese with normal theme variant
Comment 6 David King 2011-10-11 15:30:57 UTC
Created attachment 198794 [details]
cheese with dark theme variant
Comment 7 daniel g. siegel 2011-10-11 15:37:15 UTC
that seems both ok to me. actually the dark one is a bit nicer to the eyes ;)
Comment 8 David King 2011-10-16 05:40:45 UTC
Comment on attachment 198202 [details] [review]
prefer a dark GTK+ theme

Pushed to master as commit a70c15c23536c9cde0b3b32e63bdf1beb17ba1bd.