After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660619 - __SIZEOF_INT__ and __SIZEOF_POINTER__ may not be defined
__SIZEOF_INT__ and __SIZEOF_POINTER__ may not be defined
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.2.x
Other OpenBSD
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-10-01 09:37 UTC by Antoine Jacoutot
Modified: 2011-10-03 07:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
protect __SIZEOF_INT__ and __SIZEOF_POINTER__ with an ifdef (962 bytes, patch)
2011-10-01 09:37 UTC, Antoine Jacoutot
accepted-commit_now Details | Review

Description Antoine Jacoutot 2011-10-01 09:37:08 UTC
Created attachment 197951 [details] [review]
protect __SIZEOF_INT__ and __SIZEOF_POINTER__ with an ifdef

Hi.

Patch to protect __SIZEOF_INT__ and __SIZEOF_POINTER__ with an ifdef to prevent
warning: "__SIZEOF_INT__" is not defined
warning: "__SIZEOF_POINTER__" is not defined
when including gtktextattributes.h.

ok to push?
Comment 1 Matthias Clasen 2011-10-01 14:40:28 UTC
Review of attachment 197951 [details] [review]:

Looks ok, though I would prefer to keep it in a single #if.
Feel free to push with that change.
Out of interest, what compiler are you using ?
Comment 2 Antoine Jacoutot 2011-10-03 07:15:33 UTC
Thanks, committed f44b8465f1733f848b69ffde85d12dfb5e1b36e1

Compiler is GCC 4.2.1:

    Target: i386-unknown-openbsd5.0
    Configured with: OpenBSD/i386 system compiler
    Thread model: posix
    gcc version 4.2.1 20070719