After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660492 - can't login with fingerprint plugin installed
can't login with fingerprint plugin installed
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
unspecified
Other Mac OS
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-29 16:16 UTC by William Jon McCann
Modified: 2011-10-11 21:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gdm: don't show fingerprint message right away (3.50 KB, patch)
2011-10-11 18:00 UTC, Ray Strode [halfline]
committed Details | Review

Description William Jon McCann 2011-09-29 16:16:50 UTC
When the gdm-plugin-fingerprint package is installed I can't login at all. It seems to fail right away (possibly due to me not having any fingerprints stored) and this seems to confuse gdm or something.

Removing the plugin package allows me to login.
Comment 1 Ray Strode [halfline] 2011-09-30 21:42:30 UTC
does enrolling your fingerprint make the problem go away?
Comment 2 Ray Strode [halfline] 2011-10-06 22:07:41 UTC
Jon and I debugged this a few days ago.

It's caused by the "(swipe finger)" fade out animation (from not being enrolled) crossing streams with the "(swipe finger)" fade in animation.  this made the fade in animation never complete and so the whole overarching batch of steps leading to authentication never finished.

There are a few possible fixes, but right now i think the best fix is to defer fading in the "(swipe finger") animation until the fingerprint service sends a message.  Other possible fixes would have the side effect of seeing the message blink or fade in then fade out, etc, which we don't want.
Comment 3 Ray Strode [halfline] 2011-10-11 18:00:02 UTC
Created attachment 198803 [details] [review]
gdm: don't show fingerprint message right away

Right now we show "(or swipe finger)" at the user login prompt
any time we detect a fingerprint reader.

Checking for the presense of a fingerprint reader isn't really
sufficient for knowing if it is appropriate or not to show the
message, though. Often, a user's fingerprint won't be enrolled
in the system even if the machine has a fingerprint reader.

In this scenario, we end up in a situation where the code will
fade out the message right after fading it in, or worse, fade
out the message while fading it in.

The former case looks flickery and bad, and the latter case
causes the login dialog to lock up since it never completes its
"show prompt" animation.

If a user is enrolled in the system, the fingerprint pam module
tries to tell the user to swipe their finger.  We never show the
user that message because it's redundant with our own "(or swipe
finger)" message and because it uses techy words like "UPEK" and
"TouchStrip".

This commit changes the code to defer showing "(or swipe
finger)" until the fingerprint pam module forwards us its own
message. This makes it less likely we'll show the message when
fingerprint login won't work, and also removes the fingerprint
animation from the critical path "show prompt" animation.
Comment 4 drago01 2011-10-11 20:33:18 UTC
Review of attachment 198803 [details] [review]:

Makes sense, the commit message might be a bit too verbose though OTOH without asking you on IRC I didn't understand what the bug was at first.
Comment 5 Ray Strode [halfline] 2011-10-11 21:26:46 UTC
Attachment 198803 [details] pushed as 8529ca7 - gdm: don't show fingerprint message right away