After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 660358 - fix up emacs modelines
fix up emacs modelines
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-28 13:25 UTC by Dan Winship
Modified: 2011-10-11 12:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
*.js: Make emacs modelines consistent (38.34 KB, patch)
2011-09-28 13:25 UTC, Dan Winship 		committed Details | Review
*.[ch]: add emacs modeline to C files that were missing it (4.69 KB, patch)
2011-09-28 13:25 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2011-09-28 13:25:35 UTC 
I got tired of always seeing "Ignoring unknown mode `js2-mode'".

One note on the js patch; "js-indent-level" is not in the default set
of "safe" modeline variables, so emacs will warn when you try to open
a file with it set (although it gives you the option of adding that
variable to the safe list at that point). Given that 4 is the default
value anyway, we could just remove it, although then people who are
overriding it in their .emacs would end up with the wrong value in the
file...
Comment 1 Dan Winship 2011-09-28 13:25:37 UTC 
Created attachment 197662 [details] [review]
*.js: Make emacs modelines consistent

js2-mode is no longer developed and we recomment js-mode these days,
so switch the modelines to specify that, and make them consistent
across all files.
Comment 2 Dan Winship 2011-09-28 13:25:41 UTC 
Created attachment 197663 [details] [review]
*.[ch]: add emacs modeline to C files that were missing it

(excluding files that are synced from another module)
Comment 3 drago01 2011-10-11 11:15:14 UTC 
Review of attachment 197662 [details] [review]:

Not an emacs user but it looks right to me.
Comment 4 drago01 2011-10-11 11:15:40 UTC 
Review of attachment 197663 [details] [review]:

Looks good.
Comment 5 Dan Winship 2011-10-11 12:06:03 UTC 
Attachment 197662 [details] pushed as 75b824d - *.js: Make emacs modelines consistent
Attachment 197663 [details] pushed as 4333bdc - *.[ch]: add emacs modeline to C files that were missing it