GNOME Bugzilla – Bug 660262
Implicit declarations cause build failures
Last modified: 2018-05-24 10:22:54 UTC
Created attachment 197585 [details] [review] add missing declarations and #includes Hi, As the Debian maintainer for gimp-gap (2.6.0), I have encountered several breakages due to the fact that several #include directives are missing (and a couple of function declarations need to be provided by hand). The 2 problems which can (or have) occurred due to this are: - when the compiler gets stricter, it sometimes starts failing at guessing a prototype (-> build failure); - the implicit return value is int, which is too short to hold a void* on 64 bit architectures and causes various build and run-time failures. Please consider applying the attached patch (applied in Debian). Regards, Thibaut.
Comment on attachment 197585 [details] [review] add missing declarations and #includes [Setting "patch" flag and correcting mime type so this can actually be queried for.]
Thank you for your investigations and for providing the patch. the review of your patch showed that all adressed issues are already fixed in the latest GIMP-GAP git version. (see Bugreports #607924, #641078 about fixes relevant for 64 bit systems) The GAP_2_6_0 branch was not updated since 2 years. All fixes and new features were done in GIT master. GIT master is still backwards compatible to GIMP-2.6.x Probably there will be one more stable GIMP-GAP-2.6.x release where the main latest development will be merged into the 2.6 stable branch. This may happen when i start GIMP_GAP port to GIMP-2.8 (e.g. not before GIMP-2.8 is available)
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp-gap/issues/15.