After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659877 - Gtk-CRITICAL **: gtk_tree_path_compare: assertion `b->depth > 0' failed
Gtk-CRITICAL **: gtk_tree_path_compare: assertion `b->depth > 0' failed
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkTreeView
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtktreeview-bugs
gtktreeview-bugs
Depends on:
Blocks:
 
 
Reported: 2011-09-22 20:52 UTC by Alban Crequy
Modified: 2011-09-23 16:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] gtktreeviewaccessible: do not trigger an assertion (2.25 KB, patch)
2011-09-22 20:53 UTC, Alban Crequy
committed Details | Review

Description Alban Crequy 2011-09-22 20:52:16 UTC
I get the following critical message with the last git version of glib/gtk/empathy, when Empathy starts:

Gtk-CRITICAL **: gtk_tree_path_compare: assertion `b->depth > 0' failed

This is caused by model_row_inserted() in gtktreeviewaccessible.c. The attached patch fixes it.
Comment 1 Alban Crequy 2011-09-22 20:53:13 UTC
Created attachment 197292 [details] [review]
[PATCH] gtktreeviewaccessible: do not trigger an assertion

The following assertion was triggered in model_row_inserted() because
iterate_thru_children() modifies the parameter tree_model before passing it to
traverse_cells().

Gtk-CRITICAL **: gtk_tree_path_compare: assertion `b->depth > 0' failed

The stack with the bug was:

  #0  gtk_tree_path_compare at gtktreemodel.c
  #1  traverse_cells at gtktreeviewaccessible.c
  #2  model_row_inserted at gtktreeviewaccessible.c

This patch calls iterate_thru_children() with a copy of the path so that the
original is not modified.
---
 gtk/a11y/gtktreeviewaccessible.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)
Comment 2 Matthias Clasen 2011-09-22 22:42:33 UTC
Review of attachment 197292 [details] [review]:

Looks good to me, thanks.
Comment 3 Alban Crequy 2011-09-23 16:08:49 UTC
Review of attachment 197292 [details] [review]:

Committed on gtk+ git master:

commit 6ab7b87a02b5eb1af2703dc3f151442b2cf4ce9a
Author: Alban Crequy <alban.crequy@collabora.co.uk>
Date:   Thu Sep 22 16:39:06 2011 -0400