After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659743 - keyboard: pop up initially
keyboard: pop up initially
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: keyboard
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-21 16:37 UTC by Matthias Clasen
Modified: 2011-10-17 18:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: show the keyboard immediately when the user toggles it on (3.46 KB, patch)
2011-09-28 14:30 UTC, Dan Winship 		committed Details | Review

Description Matthias Clasen 2011-09-21 16:37:24 UTC 
When I don't have focus in an entry and go to the a11y menu to turn on the keyboard, apparently nothing happens. I think it would be better to always show the keyboard initially, just to make it clear that the switch had an effect.
Comment 1 Dan Winship 2011-09-28 14:30:22 UTC 
Created attachment 197675 [details] [review]
keyboard: show the keyboard immediately when the user toggles it on

Enabling the keyboard currently doesn't give much notification. Make
it so that the keyboard shows right away when it first gets turned on.
Comment 2 drago01 2011-10-17 17:43:56 UTC 
Review of attachment 197675 [details] [review]:

Looks good, one small style nit otherwise fine.

::: js/ui/keyboard.js
@@ +212,3 @@
         this._a11yApplicationsSettings = new Gio.Settings({ schema: A11Y_APPLICATIONS_SCHEMA });
         this._a11yApplicationsSettings.connect('changed', Lang.bind(this, this._settingsChanged));
+        this._settingsChanged(null);

Kind of ugly ... just don't pass anything and check for undefined instead of null.
Comment 3 Dan Winship 2011-10-17 18:52:39 UTC 
(In reply to comment #2)
> Kind of ugly ... just don't pass anything and check for undefined instead of
> null.

OK. I did it that way originally, but I felt it ended up looking sort of magical, and was clearer with an explicitly-null object there...
Comment 4 Dan Winship 2011-10-17 18:55:34 UTC 
Attachment 197675 [details] pushed as ff20fe8 - keyboard: show the keyboard immediately when the user toggles it on