If user has firewalld running then he won't see this message. But if he hasn't, I have to notify him about that or that he should enable required services manually.

We don't have any UI for enabling those services so this is an error that can't be corrected by most users.

So a few things.

 * this message (from the screenshot) seems to show up in the Local section - it should not
 * Mentioning those services is not necessary because "the correct configuration" just needs to be applied - or firewalld started.
 * There is no point in mentioning firewalld either especially since it has a terrible name that makes it sound like the firewall itself.

I think we need to have another sad computer here with a message similar to: 
"A firewall is preventing automatic printer discovery."

(In reply to comment #2)
> I think we need to have another sad computer here with a message similar to: 
> "A firewall is preventing automatic printer discovery."

Which is misleading, there might not even be a firewall running.

*** Bug 661544 has been marked as a duplicate of this bug. ***

Ubuntu also got a bug about that message on https://bugs.launchpad.net/gnome-control-center/+bug/871985

The error also assumes that firewalld is a standard component but it's rather Redhat specific it seems, it's not even packaged for Debian or Ubuntu...

Hi,

I plan to change this, but not for 3.2 because we are after string freeze.

We should inform user that it is possible that he doesn't see any printer because there is maybe a firewall involved. But sad computer doesn't suite for this well because it is possible that there just isn't any printer.

Regards

Marek

We're free of the string freeze now. Is there any plan to change this in the near future? It's a terrible string.

I would like to change it in 3.4. And I'm open to suggestions from designers how to deal with this.

It should say to user that it is possible that firewall is blocking the discovery of the printer. We can not detect this (except the FirewallD case). It should also give him a list of services the discovery possibly needs to have enabled.

Maybe it would be good to have an icon which should show a hint to user if he clicks on it (an icon with question mark or whatever shows a quick help in nowaday gnome).

Regards

Marek

Marek and I discussed this today. 

Our settings panel requires:
mdns
ipp
samba-client

I think this message is entirely inappropriate to have in GNOME because:

 * as mentioned above, firewalld is not a GNOME dependency (and I don't think it should be)
 * it isn't a good metric for whether printer discovery will work
 * if the correct firewall settings are in place to allow avahi to work then there is no need for firewalld at all

Unfortunately there does not seem to be a way to detect if a firewall is blocking the required ports. We need to work with the Fedora team to ensure that avahi is enabled and fully functional by default. And remove the offending warning and the poking of avahi etc with firewalld.

A side note about poking a hole for avahi:

As mentioned in https://bugzilla.redhat.com/show_bug.cgi?id=710061#c3 poking a hole for avahi from the add printer dialog seems wrong. One of the reasons for this is that it would be very strange to have other, completely unrelated, avahi enabled services (like music sharing etc) in the desktop affected by this change - and only for the 5 minute discovery period of the dialog.

Unfortunately, now we are back into string freeze again, so it is probably too late for 3.4. Lets do this in early 3.5, that also gives use enough time to fix firewall rules in Fedora for F18.

What is the status of this?

I will remove the whole firewalld support from the "Printers" panel. I plan to remove it as a part of implementation of the new features (#678637).

Fixed since 3.6.