GNOME Bugzilla – Bug 659634
windowManager: shade the actor, not the texture
Last modified: 2011-09-20 18:58:50 UTC
Applying the "dim window" effect to the MetaWindowActor has two avantages: first it avoids triggering bugs where ClutterOffscreenEffect doesn't handle clone paint correctly. Second, it avoids showing the window as dimmed in alt-Tab and the overview, which is weird. The small downside of this is that the shadow becomes slightly gray when the window dimmed, which is wrong - if we switched from blending with gray to a combination of desaturation and darkening, this problem wouldn't happen. Revert out the addition of startY to the shader, since we don't need it and fix the application of alpha, since we need to handle alpha correctly for the shadow.
Created attachment 197104 [details] [review] windowManager: shade the actor, not the texture
Review of attachment 197104 [details] [review]: Looks good, just one stale parameter just remove it before pushing. ::: js/ui/windowManager.js @@ +276,3 @@ }); else + getWindowDimmer(actor, window).dimFraction = 1.0; No need to pass window here.
Committed with leftovers fixd. Attachment 197104 [details] pushed as fb30822 - windowManager: shade the actor, not the texture