After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659634 - windowManager: shade the actor, not the texture
windowManager: shade the actor, not the texture
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-20 18:29 UTC by Owen Taylor
Modified: 2011-09-20 18:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
windowManager: shade the actor, not the texture (4.94 KB, patch)
2011-09-20 18:29 UTC, Owen Taylor
committed Details | Review

Description Owen Taylor 2011-09-20 18:29:04 UTC
Applying the "dim window" effect to the MetaWindowActor has two avantages:
first it avoids triggering bugs where ClutterOffscreenEffect doesn't handle
clone paint correctly. Second, it avoids showing the window as dimmed in
alt-Tab and the overview, which is weird.

The small downside of this is that the shadow becomes slightly gray when
the window dimmed, which is wrong - if we switched from blending with gray
to a combination of desaturation and darkening, this problem wouldn't
happen.

Revert out the addition of startY to the shader, since we don't need it
and fix the application of alpha, since we need to handle alpha correctly
for the shadow.
Comment 1 Owen Taylor 2011-09-20 18:29:08 UTC
Created attachment 197104 [details] [review]
windowManager: shade the actor, not the texture
Comment 2 drago01 2011-09-20 18:50:31 UTC
Review of attachment 197104 [details] [review]:

Looks good, just one stale parameter just remove it before pushing.

::: js/ui/windowManager.js
@@ +276,3 @@
                              });
         else
+            getWindowDimmer(actor, window).dimFraction = 1.0;

No need to pass window here.
Comment 3 Owen Taylor 2011-09-20 18:58:46 UTC
Committed with leftovers fixd.

Attachment 197104 [details] pushed as fb30822 - windowManager: shade the actor, not the texture