After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 659127 - Interface acts weirdly with profile names containing ampersands
Interface acts weirdly with profile names containing ampersands
Status: RESOLVED FIXED
Product: gnome-color-manager
Classification: Core
Component: general
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-color-manager-maint
gnome-color-manager-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-15 06:14 UTC by Jan Alexander Steffens (heftig)
Modified: 2011-09-15 08:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Thinkpad FlexView profile (1.09 KB, application/vnd.iccprofile)
2011-09-15 06:14 UTC, Jan Alexander Steffens (heftig)
Details

Description Jan Alexander Steffens (heftig) 2011-09-15 06:14:34 UTC
Created attachment 196590 [details]
Thinkpad FlexView profile

I use a profile named "Wide viewing angle & High density FlexView Display" for my monitor. This name contains an ampersand, and I believe this is the cause for some interface weirdness such as g-c-m using another profile's name for this profile.

Both gnome-control-center and gcm-viewer emit warnings like this one:

(gcm-viewer:11704): Gtk-WARNING **: Failed to set text from markup due to error parsing markup: Error on line 1: Entity did not end with a semicolon; most likely you used an ampersand character without intending to start an entity - escape ampersand as &

It seems the profile name is not escaped correctly?

I have attached the profile in use.
Comment 1 Richard Hughes 2011-09-15 08:31:53 UTC
Thanks for reporting this bug, it's quite nice to have an easy-to-fix self contained bug to start the day!

I've pushed this to gnome-color-manager for the gcm-viewer program:

commit 1ae3d38908757bc788d95c473b3c1b41cbbc2962
Author: Richard Hughes <richard@hughsie.com>
Date:   Thu Sep 15 09:24:03 2011 +0100

    Escape profile titles that have markup in the titles
    
    This ensures we can show profiles with '<', '>' and '&' in the title.
    
    Resolves https://bugzilla.gnome.org/show_bug.cgi?id=659127

And this to gnome-control-center for the panel:

commit 104aadaca9194cd99f217f10b3e9d735a3cc9cda
Author: Richard Hughes <richard@hughsie.com>
Date:   Thu Sep 15 09:30:14 2011 +0100

    color: Escape profile titles that have markup in the titles
    
    This ensures we can show profiles with '<', '>' and '&' in the title.
    
    Resolves https://bugzilla.gnome.org/show_bug.cgi?id=659127

Thanks!