GNOME Bugzilla – Bug 659087
celt: various cleanups/fixes
Last modified: 2011-09-19 07:40:02 UTC
Though while submitting a small patch to libcelt, I'm told it's essentially obsolete, and all work is going into Opus now, so I won't hack on this further.
Created attachment 196536 [details] [review] celtenc: allow actually overriding frame size
Created attachment 196537 [details] [review] celtdec: fix error checking with libcelt 0.11 The return value of celt_decode has changed, newer versions now return positive values on success.
Created attachment 196538 [details] [review] celtenc: do not use invalid buffer timestamps
Created attachment 196539 [details] [review] celtenc: cleanup header creation Avoid an extra copy via a temporary fixed size stack buffer. Use libcelt's header size to allocate a buffer of the correct size in the first place (libcelt has an off by 4 there, so account for this). While there, make size unsigned, and granpos signed.
Created attachment 196540 [details] [review] celt: a bit more error checking on header parsing
commit fe0a2ec885226b2fa004b8d30514ce0f81ed3e28 Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> Date: Wed Sep 14 20:22:42 2011 +0100 celt: a bit more error checking on header parsing https://bugzilla.gnome.org/show_bug.cgi?id=659087 commit d8684fffa12a13d32efb8e74b8cd23519b3d76f6 Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> Date: Wed Sep 14 19:56:40 2011 +0100 celtenc: cleanup header creation Avoid an extra copy via a temporary fixed size stack buffer. Use libcelt's header size to allocate a buffer of the correct size in the first place (libcelt has an off by 4 there, so account for this). While there, make size unsigned, and granpos signed. https://bugzilla.gnome.org/show_bug.cgi?id=659087 commit 06764fcd3f6c738075cf52f8858a157cf8a350b9 Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> Date: Wed Sep 14 19:09:30 2011 +0100 celtenc: do not use invalid buffer timestamps https://bugzilla.gnome.org/show_bug.cgi?id=659087 commit 37e688197d65b632606e32d2dd758b10a2767d0b Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> Date: Wed Sep 14 17:26:05 2011 +0100 celtdec: fix error checking with libcelt 0.11 The return value of celt_decode has changed, newer versions now return positive values on success. https://bugzilla.gnome.org/show_bug.cgi?id=659087 commit 90b2484648e3370edce45d53b29a3a9af6d4cd90 Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> Date: Wed Sep 14 17:07:50 2011 +0100 celtenc: allow actually overriding frame size https://bugzilla.gnome.org/show_bug.cgi?id=659087