GNOME Bugzilla – Bug 658948
switch on network password prompt is wrong
Last modified: 2011-10-17 13:33:24 UTC
Created attachment 196397 [details] screenshot Using a switch to turn on showing the password isn't right. For one the label is an action "Show password" and an action can't be on or off. This is also inconsistent with all of the other password dialogs in GNOME (any of which could have similar features for similar reasons but currently don't). We discussed this on #gnome-design a bit and I think we should remove this for now and add it back later as a context menu item in all password (invisible character entries) as well as automatically doing last-character-reveal when using an on-screen-keyboard.
(In reply to comment #0) > This is also > inconsistent with all of the other password dialogs in GNOME the issue is that wireless passwords are generally not as secret as other passwords (in particular, anyone in the room with you when you type it is probably also allowed on that network anyway). And many wireless passwords are long hex strings that are hard to type correctly.
Created attachment 196417 [details] [review] network-agent: Remove "Show password" switch While the ability to show the password can be useful at times, the existing implementation is problematic: 1) The use of a switch is wrong (as even noted in a code comment). 2) It is inconsistent with any other password dialog (login screen, polkit). In lack of a properly designed solution (for all password dialogs), the designers agreed to remove the switch for now. Sorry, had this lying around a couple of days to figure out an issue with the entry width.
Review of attachment 196417 [details] [review]: Don't see anything wrong with the code, but it sucks to regress like this.
Created attachment 196511 [details] [review] network-agent: Remove "Show password" switch Also remove obsolete CSS.
Review of attachment 196511 [details] [review]: Still fine. (Even though it is a sub optimal solution ... we don't have much time left).
So, with 3.2.1 around the corner, I brought this up again on #gnome-design: <jimmac> fmuellner, i lean towards considering this a regular password entry <fmuellner> jimmac: what does that mean? <jimmac> the only sane wifi authorisation is through a passcode, not the super long key <jimmac> so I would just have the entry toggle visible on the context menu as jon suggests for all passwords <fmuellner> good, then bug 659275 needs review
Attachment 196511 [details] pushed as ba110f2 - network-agent: Remove "Show password" switch The change had rt approval for 3.2, but was not pushed for lack of a replacement.