After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658817 - No need to prepare self contact in teleapthyClient
No need to prepare self contact in teleapthyClient
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-12 12:36 UTC by Xavier Claessens
Modified: 2012-01-12 19:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
telepathyClient: No need to prepare connection's self contact (7.39 KB, patch)
2011-09-12 12:37 UTC, Xavier Claessens 		none Details | Review
telepathyClient: No need to prepare connection's self contact (7.45 KB, patch)
2011-09-12 12:47 UTC, Xavier Claessens 		accepted-commit_now Details | Review
telepathyClient: No need to prepare channel contacts (15.22 KB, patch)
2011-12-05 10:23 UTC, Xavier Claessens 		accepted-commit_now Details | Review

Description Xavier Claessens 2011-09-12 12:36:36 UTC 
telepathy-glib master (future 0.15.6) does it for us.
Comment 1 Xavier Claessens 2011-09-12 12:37:05 UTC 
Created attachment 196250 [details] [review]
telepathyClient: No need to prepare connection's self contact

tp-glib does it for us since version 0.15.6
Comment 2 Xavier Claessens 2011-09-12 12:47:52 UTC 
Created attachment 196251 [details] [review]
telepathyClient: No need to prepare connection's self contact

tp-glib does it for us since version 0.15.6
Comment 3 Jasper St. Pierre (not reading bugmail) 2011-09-12 12:50:03 UTC 
Review of attachment 196251 [details] [review]:

Looks good. Feel free to commit after tp-glib 0.15.6 is released.
Comment 4 Jasper St. Pierre (not reading bugmail) 2011-11-04 20:44:00 UTC 
Ping?
Comment 5 Xavier Claessens 2011-11-10 07:28:27 UTC 
This is still on my todo list, don't worry. Just have plenty other stuff to work on those days ;-)
Comment 6 Xavier Claessens 2011-12-05 10:23:27 UTC 
Created attachment 202794 [details] [review]
telepathyClient: No need to prepare channel contacts

tp-glib does it for us since version 0.15.6
Comment 7 Xavier Claessens 2011-12-05 10:25:14 UTC 
Sorry for the delay, but here is an updated patch. tp-glib now gives prepared contact for everything, so I completely removed all those ugly extra async operations :)

Patch is made on top of 3.2 branch because master requires glib 2.31 that I don't have, but I think it should apply on master just fine.
Comment 8 Jasper St. Pierre (not reading bugmail) 2012-01-12 19:51:58 UTC 
Review of attachment 202794 [details] [review]:

"4 files changed, 21 insertions(+), 207 deletions(-)"

Yay! Go for it, looks fine to me.
Comment 9 Xavier Claessens 2012-01-12 19:56:34 UTC 
thanks, merged