After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658806 - sign error in string hash implementation
sign error in string hash implementation
Status: RESOLVED FIXED
Product: dconf
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: dconf-maint
dconf-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-12 11:26 UTC by Alexander Larsson
Modified: 2011-09-12 12:16 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Alexander Larsson 2011-09-12 11:26:13 UTC
static guint32 djb_hash (const gchar *key)

Takes an argument of undefined signedness and uses it as is, this is broken for compilers that treat "char" as signed (which is legal).
Comment 1 Allison Karlitskaya (desrt) 2011-09-12 12:00:39 UTC
ah!  Sorry, Alex.  I'd forgotten about this.