After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658507 - better comboboxes for right to left languages
better comboboxes for right to left languages
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkComboBox
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-09-07 20:16 UTC by Arash Mousavi
Modified: 2011-09-09 15:46 UTC
See Also:
GNOME target: 3.2
GNOME version: ---

Attachments
combobox: implement get_path_for_child() for GtkComboBox (4.86 KB, patch)
2011-09-08 22:22 UTC, Cosimo Cecchi 		committed Details | Review
combobox-entry: switch radius/borders when in RTL mode (5.33 KB, patch)
2011-09-08 22:25 UTC, Cosimo Cecchi 		none Details | Review

Description Arash Mousavi 2011-09-07 20:16:18 UTC 
While using a RTL language like Persian, arrow of comboboxes shows at the left. This way borders become messy in Adwaita. I've taken a screenshot from a combobox in network dialog:
http://www.wuala.com/api/preview/arash-m/Photos/Public/combo.png
Comment 1 Cosimo Cecchi 2011-09-08 22:22:53 UTC 
Created attachment 196044 [details] [review]
combobox: implement get_path_for_child() for GtkComboBox

Turns out we need to implement get_path_for_child() in GtkComboBox to allow the themes to use nth-child(first) and nth-child(last) to differentiate the LTR and RTL cases. This patch is supposed to go together with an additional theme patch to add the new style classes.
Comment 2 Cosimo Cecchi 2011-09-08 22:25:29 UTC 
Created attachment 196046 [details] [review]
combobox-entry: switch radius/borders when in RTL mode

Theme patch for reference.
Comment 3 Matthias Clasen 2011-09-09 15:13:14 UTC 
Review of attachment 196044 [details] [review]:

Hmm, ok. A little disconcerting that we are constantly creating these paths, even though direction basically never changes. But I guess it is the same for other container where we implemented this...
Comment 4 Cosimo Cecchi 2011-09-09 15:46:53 UTC 
Attachment 196044 [details] pushed as e97ed43 - combobox: implement get_path_for_child() for GtkComboBox

Thanks, pushed to master.