After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658457 - List my encrypted /home partition as an object
List my encrypted /home partition as an object
Status: RESOLVED OBSOLETE
Product: gvfs
Classification: Core
Component: [obsolete] gdu volume monitor
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Tomas Bzatek
gvfs-maint
: 659671 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-09-07 12:43 UTC by Vincent Untz
Modified: 2018-04-13 18:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (2.32 KB, patch)
2011-09-29 14:07 UTC, Tomas Bzatek
none Details | Review

Description Vincent Untz 2011-09-07 12:43:14 UTC
My /home is an encrypted partition, and as such, it appears as a removable device. This means I always get the removable devices notification icon in gnome-shell, even though I don't have anything else.

I don't think it's right for gvfs to display this partition as a removable device anyway. I mean, it's my /home partition :-)
Comment 1 Vincent Untz 2011-09-07 13:38:40 UTC
Cosimo might be able to comment if it's actually something that should be done at the gnome-shell level (ie, hide the mount there).
Comment 2 Tomas Bzatek 2011-09-08 14:51:33 UTC
Probably caused by bug 656228 (forgot to put the bugzilla reference in commit 	cbc96e8fffa0d63fa).

Previously we showed a volume having no mount associated, leading to inappropriate errors. I wonder if it was your case before the change or you had no icon at all. Is your /home mount in fstab?
Comment 3 Vincent Untz 2011-09-08 18:24:42 UTC
(In reply to comment #2)
> Previously we showed a volume having no mount associated, leading to
> inappropriate errors. I wonder if it was your case before the change or you had
> no icon at all. Is your /home mount in fstab?

Hrm, I think the notification icon in gnome-shell was not showing my encrypted /home before, indeed.

And yes, my /home mount is in fstab.
Comment 4 Emmanuele Bassi (:ebassi) 2011-09-15 12:52:51 UTC
same happens here with an encrypted /home

this bug has another interesting side-effect: Tracker will try to recursively index /home because it thinks that the partition is on a removable drive, thus will undo all the safeties in place to avoid excessive I/O and CPU usage.
Comment 5 Cosimo Cecchi 2011-09-22 01:00:02 UTC
*** Bug 659671 has been marked as a duplicate of this bug. ***
Comment 6 Tomas Bzatek 2011-09-23 17:20:58 UTC
FYI, it turns out that only the mount object has been exposed by the referenced patch, we still used to show a volume and a drive for the /home mount. The drive is NOT marked as removable, only the volume has the can_mount flag set and the mount has can_unmount=1 (and this is actually true if you're root). This is probably the thing that made tools like tracker confused.

I'm thinking about filtering out whole object trees where the end presentables are already unlocked and mounted in paths that should be ignored.
Comment 7 Tomas Bzatek 2011-09-29 14:07:37 UTC
Created attachment 197768 [details] [review]
proposed patch

A rather risky patch where we change the way we present LUKS volumes a bit. Instead presenting the cryptotext ones (parent) we present cleartext volumes (nested) filtered through more tests. Overall it seems to be working fine, I'd appreciate futher testing on different systems.

Both nautilus and gnome-shell are showing GVolumeMonitor volumes withouth further filtering, we need to do that on gvfs side.
Comment 8 Vincent Untz 2011-09-29 14:37:53 UTC
I can only say this makes things look the right way for me :-)
Comment 9 David Zeuthen (not reading bugmail) 2011-10-28 16:11:39 UTC
(In reply to comment #6)
> FYI, it turns out that only the mount object has been exposed by the referenced
> patch, we still used to show a volume and a drive for the /home mount. The
> drive is NOT marked as removable, only the volume has the can_mount flag set
> and the mount has can_unmount=1 (and this is actually true if you're root).
> This is probably the thing that made tools like tracker confused.

Indeed. Tracker is making assumptions that it shouldn't be making. Therefore, adjusting bug summary to use the word 'object' instead of 'removable device'.

Btw, in the future, please attach the output of 'gvfs-mount -li' and relevant entries from /etc/fstab as it makes it easier to figure out what you think the problem is.

Also, bug 660595 is related to this.
Comment 10 Felix Möller 2012-07-30 10:40:42 UTC
Should this be applied it is not in http://git.gnome.org/browse/gvfs/tree/monitor/gdu/ggduvolumemonitor.c yet
Comment 11 Ondrej Holy 2018-04-13 18:14:41 UTC
Gdu volume monitor has been superseded by udisks2 volume monitor long time ago. I am closing this bug because many have been changed since this was reported. If this is still an issue with the recent gvfs releases, please reopen and change component to udisks2 volume monitor.