After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658441 - Vinagre doesn't remember passwords
Vinagre doesn't remember passwords
Status: RESOLVED FIXED
Product: vinagre
Classification: Applications
Component: general
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: vinagre-maint
vinagre-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-07 09:52 UTC by Julien Olivier
Modified: 2013-02-25 03:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
log of vinagre running with the --gtk-vnc-debug switch (6.03 KB, text/plain)
2012-10-31 14:36 UTC, Philippe Desautels
  Details
Fix value of save_in_keyring output parameter (1.18 KB, patch)
2013-02-01 22:48 UTC, Evangelos Foutras
committed Details | Review

Description Julien Olivier 2011-09-07 09:52:25 UTC
I have some VNC connections configured in vinagre that need a password. Each time I connect to one of them, I'm prompted for the password. I enter it and check "remember password" but the next time I'm still prompted for the password.
Comment 1 Julien Olivier 2011-09-07 09:55:55 UTC
Please also note that I'm sure it used to work before, but I recently removed my keychain from seahorse and re-created it.
Comment 2 ferconsigli 2011-11-01 02:28:43 UTC
Same here. I have noticed that if I disconnect and try to connect again, the password IS remembered. BUT if I close the application and open it again, the I'm prompted for password again.
I think it stopped working in the same or a close update to that one in which the bookmarks toolbar disappeared.
Comment 3 ferconsigli 2011-11-01 02:31:40 UTC
Even though this bugs is registered in version 3.1.x, I'm having this issue in 3.2.1 and using XFCE. Maybe it's a bug related to XFCE and it works ok on Gnome, as it's strange that only two of us reported it. What desktop are you using, Julien Olivier?
Comment 4 Julien Olivier 2011-11-01 10:03:24 UTC
(In reply to comment #3)
> Even though this bugs is registered in version 3.1.x, I'm having this issue in
> 3.2.1 and using XFCE. Maybe it's a bug related to XFCE and it works ok on
> Gnome, as it's strange that only two of us reported it. What desktop are you
> using, Julien Olivier?

I use gnome-shell 3.2.1 on Ubuntu Oneiric. Maybe only two of us reported it because very few people use VNC with a password...
Comment 5 bagchis 2011-11-05 02:13:01 UTC
(In reply to comment #4)
I experience the exact problem as described above. I am on gnome-shell 3.2.0 on a Ubuntu 11.10 install.
Comment 6 Luke Symes 2011-12-03 21:41:13 UTC
I can confirm this bug on Ubuntu 11.10 in Unity. It is very annoying having to always enter my password!
Comment 7 NonSek 2012-02-06 10:58:25 UTC
Same problem here, with Ubuntu 11.10 64-bit using Unity or XFCE (different users). And also with Linux Mint 12 64-bit. The credentials are not saved.

 Other people has filed the same bug on the Ubuntu package page (#876105):

https://bugs.launchpad.net/ubuntu/+source/vinagre/+bug/876105
Comment 8 Arne 2012-05-23 05:36:48 UTC
(In reply to comment #0)
> I have some VNC connections configured in vinagre that need a password. Each
> time I connect to one of them, I'm prompted for the password. I enter it and
> check "remember password" but the next time I'm still prompted for the
> password.

Same here.

Worked in latest version contained in ubuntu 10.04 but started forgetting passwords in vinagre 3.4.1 (contained in ubuntu 12.04).
Comment 9 Tom Metro 2012-10-23 16:18:03 UTC
Also seen in vinagre 3.4.2 in Ubuntu 12.04.1 (64-bit) running under Cinnamon desktop.
Comment 10 Philippe Desautels 2012-10-31 14:36:48 UTC
Created attachment 227731 [details]
log of vinagre running with the --gtk-vnc-debug switch
Comment 11 Philippe Desautels 2012-10-31 14:37:15 UTC
Same here. Vinagre will not remember passwords as it did in the past. The only way I was able to get it to remember the password once was : 

1. Open a new vnc connection to any host (which asks for a password)
2. Enter password and click on Authenticate (checking the 'Remember this credential' box has no effect here)
3. While connection is still open, select Bookmarks > Add bookmark
4. Save bookmark
5. Close connection
6. Select Bookmark > yourBookmark
7. The login box will appear asking for your password again. Enter password again and click 'Authenticate' (again, checking the 'Remember this credential' box has no effect here)
8. Disconnect.
9. AGAIN, select Bookmark > yourBookmark
10. At this point, connection is initiated without requiring a password

My system :

[philippe@corestation ~]$ uname -a
Linux corestation 3.5.4-2.fc17.i686 #1 SMP Wed Sep 26 22:32:49 UTC 2012 i686 i686 i386 GNU/Linux

[philippe@corestation ~]$ cat /etc/fedora-release 
Fedora release 17 (Beefy Miracle)

[philippe@corestation ~]$ rpm -q vinagre
vinagre-3.4.2-1.fc17.i686

And attached is a log of vinagre running with the --gtk-vnc-debug switch.
Comment 12 Evangelos Foutras 2013-02-01 22:48:33 UTC
Created attachment 235047 [details] [review]
Fix value of save_in_keyring output parameter

When the vinagre_utils_ask_credential() utility function was rewritten in Vala [1], a NULL check was incorrectly translated to Vala as-is.

The above causes the new vinagre_utils_request_credential() function to always return FALSE as the value of the save_in_keyring output parameter.

Attached is a patch that fixes the issue for me.

After this is solved, bug 685041 will need to be revisited because if a wrong password is given at first, subsequent attempts with correct credentials will end up calling secret_password_store_sync() with user = NULL. (I believe this is because vinagre_tab_remove_credentials_from_keyring() gets called during the failed first and sets the username to NULL.)

[1] see commit 1c0c2d0f53bc3a5b7240aa3907d5d554696c7ae6
Comment 13 David King 2013-02-10 14:35:32 UTC
Comment on attachment 235047 [details] [review]
Fix value of save_in_keyring output parameter

Thaks for the patch, I pushed it to master as commit e2f8f97f4c997e298c9df513803772ee9368c3a7.