After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658007 - workspacesView: Only connect to nWorkspacesChanged after we've lazily inited
workspacesView: Only connect to nWorkspacesChanged after we've lazily inited
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-01 20:10 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2011-09-01 20:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
workspacesView: Only connect to nWorkspacesChanged after we've lazily inited (2.22 KB, patch)
2011-09-01 20:10 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2011-09-01 20:10:09 UTC 
Simple fix for a warning, nothing too serious
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-09-01 20:10:11 UTC 
Created attachment 195439 [details] [review]
workspacesView: Only connect to nWorkspacesChanged after we've lazily inited

We lazily init this._workspaces, so we shouldn't try to run any code that uses
it until after it's been created.
Comment 2 Owen Taylor 2011-09-01 20:19:04 UTC 
Review of attachment 195439 [details] [review]:

There feels like there is a bit of weirdness here in that _workspaces is updated after we've shown and hidden, then we toss it before showing it again, but looks like it works and eliminates the warning.
Comment 3 Jasper St. Pierre (not reading bugmail) 2011-09-01 20:26:06 UTC 
Attachment 195439 [details] pushed as 3aa904d - workspacesView: Only connect to nWorkspacesChanged after we've lazily inited