After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657963 - themingengine: remove xthickness FIXME from gtk_render_line() code
themingengine: remove xthickness FIXME from gtk_render_line() code
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Class: GtkStyleContext
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-09-01 17:13 UTC by Cosimo Cecchi
Modified: 2011-09-02 19:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
themingengine: remove xthickness FIXME from gtk_render_line() code (2.99 KB, patch)
2011-09-01 17:13 UTC, Cosimo Cecchi 		none Details | Review
themingengine: remove xthickness FIXME from gtk_render_line() code (2.97 KB, patch)
2011-09-01 18:02 UTC, Cosimo Cecchi 		none Details | Review
themingengine: remove xthickness FIXME from gtk_render_line() code (2.96 KB, patch)
2011-09-01 18:03 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2011-09-01 17:13:52 UTC 
See attached patch. We hardcode lines of different color when calling gtk_render_line().
Comment 1 Cosimo Cecchi 2011-09-01 17:13:55 UTC 
Created attachment 195413 [details] [review]
themingengine: remove xthickness FIXME from gtk_render_line() code

The gtk_render_line() code has a FIXME (coming from the 2.x migration I
suppose) about using xthickness, and it actually hardcodes two lines of
different color instead of drawing a single one.
Since we don't support xthickness anymore, make gtk_render_line() do
what it says, i.e. just draw an 1px line colored with the current
border-color.
Comment 2 Cosimo Cecchi 2011-09-01 18:02:22 UTC 
Created attachment 195416 [details] [review]
themingengine: remove xthickness FIXME from gtk_render_line() code

The gtk_render_line() code has a FIXME (coming from the 2.x migration I
suppose) about using xthickness, and it actually hardcodes two lines of
different color instead of drawing a single one.
Since we don't support xthickness anymore, make gtk_render_line() do
what it says, i.e. just draw an 1px line colored with the current
border-color.
Comment 3 Cosimo Cecchi 2011-09-01 18:03:06 UTC 
Created attachment 195417 [details] [review]
themingengine: remove xthickness FIXME from gtk_render_line() code

Right patch this time, I actually meant to use color and not border-color here.
Comment 4 Matthias Clasen 2011-09-02 01:55:05 UTC 
Sounds fine to me.
Comment 5 Cosimo Cecchi 2011-09-02 19:13:20 UTC 
Attachment 195417 [details] pushed as f5e758b - themingengine: remove xthickness FIXME from gtk_render_line() code

Thanks, pushed to master.