After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657894 - After hitting enter, the password disappears
After hitting enter, the password disappears
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-01 03:24 UTC by Cosimo Cecchi
Modified: 2011-10-17 21:37 UTC
See Also:
GNOME target: ---
GNOME version: 3.1/3.2


Attachments
gdm: don't clear bullets while authenticating (2.06 KB, patch)
2011-10-17 05:54 UTC, Ray Strode [halfline]
committed Details | Review

Description Cosimo Cecchi 2011-09-01 03:24:46 UTC
After confirming the password, the entry holding the password string clears; it should keep the password string in and have an insensitive state instead. This is more annoying when entering the wrong password because of the authentication timeout.
Comment 1 Ray Strode [halfline] 2011-09-17 22:41:30 UTC
you want to be able to edit your bullets after it fails?

or are you just saying that the time spent authenticating needs to be more polished?
Comment 2 Cosimo Cecchi 2011-09-17 22:47:50 UTC
(In reply to comment #1)
> you want to be able to edit your bullets after it fails?
> 
> or are you just saying that the time spent authenticating needs to be more
> polished?

What I mean is for the time spent between pressing Enter and going to another state (both hide for a successful login and going back to the prompt in case of failure) the entry should keep the bullets, but be insensitive.
Comment 3 Ray Strode [halfline] 2011-09-18 03:10:39 UTC
okay, makes sense
Comment 4 Ray Strode [halfline] 2011-10-17 05:54:38 UTC
Created attachment 199172 [details] [review]
gdm: don't clear bullets while authenticating

Users don't expect the bullets they just typed into an entry
field to disappear as soon as they hit enter.

Instead, the want the dialog to become insensitive during the
authentication process, so that it's clear that what they typed
in is being processed.
Comment 5 Jasper St. Pierre (not reading bugmail) 2011-10-17 12:02:08 UTC
Review of attachment 199172 [details] [review]:

::: js/gdm/loginDialog.js
@@ +1063,3 @@
                          this._promptFingerprintMessage.hide();
+                         this._promptEntry.reactive = true;
+                         if (this._promptEntry.has_style_pseudo_class('insensitive'))

This if() isn't necessary -- remove_style_pseudo_class already checks if the class name exists.
Comment 6 Ray Strode [halfline] 2011-10-17 21:37:56 UTC
Good catch, thanks.

Attachment 199172 [details] pushed as ca5ab20 - gdm: don't clear bullets while authenticating