After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657746 - Port to the new IndividualAggregator::individuals-changed-detailed signal
Port to the new IndividualAggregator::individuals-changed-detailed signal
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Meta Contacts
3.1.x
Other All
: Normal minor
: ---
Assigned To: empathy-maint
Depends on: 657282
Blocks:
 
 
Reported: 2011-08-30 18:11 UTC by Philip Withnall
Modified: 2011-09-12 21:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Port EmpathyIndividualManager to the new IndividualAggregator::individuals-changed-detailed signal (3.54 KB, patch)
2011-08-30 18:14 UTC, Philip Withnall
committed Details | Review

Description Philip Withnall 2011-08-30 18:11:00 UTC
See bug #657282. Patch coming.

This should basically not affect Empathy at all, apart from meaning it doesn't use deprecated folks API (IndividualAggregator::individuals-changed is being deprecated, but not removed).
Comment 1 Philip Withnall 2011-08-30 18:14:02 UTC
Created attachment 195237 [details] [review]
Port EmpathyIndividualManager to the new IndividualAggregator::individuals-changed-detailed signal

Empathy's folks dependency will need to be bumped to 0.6.2 (or whichever version the new signal gets released in) when this is committed.
Comment 2 Guillaume Desmottes 2011-08-31 08:58:25 UTC
Review of attachment 195237 [details] [review]:

++

Feel free to commit once the folks bits have been released and Empathy and jhbuild depends of the right version.
Comment 3 Philip Withnall 2011-09-04 16:39:23 UTC
I've just pushed this to folks, so the Empathy patch can be pushed as soon as folks 0.6.2 is released (which should be in the next few days).
Comment 4 Travis Reitter 2011-09-09 17:01:03 UTC
(In reply to comment #3)
> I've just pushed this to folks, so the Empathy patch can be pushed as soon as
> folks 0.6.2 is released (which should be in the next few days).

This release (and a bug-fix release, 0.6.2.1) are out, so it should be safe to merge this patch.
Comment 5 Guillaume Desmottes 2011-09-12 07:30:28 UTC
Go for it (don't forget to update configure.ac)
Comment 6 Philip Withnall 2011-09-12 21:19:45 UTC
Comment on attachment 195237 [details] [review]
Port EmpathyIndividualManager to the new IndividualAggregator::individuals-changed-detailed signal

Merged, with the folks dependency bumped to 0.6.2.

commit dafc0ff233c2d02c607bb6ee67e714ba698319fc
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Mon Aug 29 20:43:22 2011 +0100

    individual-manager: Port to the new individuals_changed_detailed signal
    
    Closes: bgo#657746

 configure.ac                            |    2 +-
 libempathy/empathy-individual-manager.c |   35 +++++++++++++++++++++++--------
 2 files changed, 27 insertions(+), 10 deletions(-)