After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657675 - audio: re-enable bits that depend on pbutils, disabled b/c of circular dependency
audio: re-enable bits that depend on pbutils, disabled b/c of circular depend...
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 659692 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-08-30 08:48 UTC by Marvin Schmidt
Modified: 2018-11-03 11:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gst-libs: Temporarily remove dependency of gstaudio on gstpbutils (2.45 KB, patch)
2011-09-21 11:32 UTC, Edward Hervey
committed Details | Review

Description Marvin Schmidt 2011-08-30 08:48:21 UTC
Trying to build current 0.11 branch (811a896 playsink: fix ts_offset refcounting) fails with the following error:

[snip]
  CC     libgstpbutils_0.11_la-gstpluginsbaseversion.lo
  CC     libgstpbutils_0.11_la-pbutils.lo
  CC     libgstpbutils_0.11_la-codec-utils.lo
  CC     libgstpbutils_0.11_la-descriptions.lo
In file included from ../../../gst-libs/gst/audio/audio.h:27:0,
                 from descriptions.c:45:
../../../gst-libs/gst/audio/multichannel.h:21:39: fatal error: gst/audio/audio-enumtypes.h: No such file or directory
compilation terminated.
make[1]: *** [libgstpbutils_0.11_la-descriptions.lo] Error 1


audio-enumtypes.h wasn't yet created at that point, because the audio library is build after pbutils as it links against it

Due to
http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?h=0.11&id=c81c62d03a183eb524a88485a5a0f48d7f687588
pbutils depends on the audio and hence creating a circular dependency between the two.
Comment 1 Sebastian Dröge (slomo) 2011-08-30 14:35:59 UTC
And this really is a circular dependency because gstbaseaudiodecoder.c needs gst/pbutils/descriptions.h
Comment 2 Sebastian Dröge (slomo) 2011-09-21 11:16:55 UTC
*** Bug 659692 has been marked as a duplicate of this bug. ***
Comment 3 Edward Hervey 2011-09-21 11:32:44 UTC
Created attachment 197145 [details] [review]
gst-libs: Temporarily remove dependency of gstaudio on gstpbutils
Comment 4 Edward Hervey 2011-09-23 14:20:44 UTC
commit 3f45eb1cfcb7937bbb621b23fa4f2b303c3fcd54
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Wed Sep 21 13:30:43 2011 +0200

    gst-libs: Temporarily remove dependency of gstaudio on gstpbutils
    
    Also re-order the SUBDIRS in the higher-level Makefile so it cleanly
    installs.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=657675
Comment 5 Edward Hervey 2011-09-23 14:21:10 UTC
I am leaving this bug open so we can fix it properly later on
Comment 6 Sebastian Dröge (slomo) 2014-01-21 09:04:50 UTC
What should we do about this?
Comment 7 GStreamer system administrator 2018-11-03 11:19:27 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/52.