After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657426 - Adding border width adds bottom padding
Adding border width adds bottom padding
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Wacom
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Peter Hutterer
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-08-26 10:44 UTC by Bastien Nocera
Modified: 2011-08-27 11:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0 padding (27.86 KB, image/png)
2011-08-26 10:46 UTC, Bastien Nocera
Details
12 padding (27.18 KB, image/png)
2011-08-26 10:46 UTC, Bastien Nocera
Details
24 padding (30.01 KB, image/png)
2011-08-26 10:47 UTC, Bastien Nocera
Details
visible borders (40.06 KB, image/png)
2011-08-26 12:50 UTC, Matthias Clasen
Details

Description Bastien Nocera 2011-08-26 10:44:41 UTC
Changing the container border width:
        grid = WID ("main-grid");
        gtk_container_add (GTK_CONTAINER (self), grid);
-       gtk_container_set_border_width (GTK_CONTAINER (self), 24);
+       gtk_container_set_border_width (GTK_CONTAINER (self), 0);

You can see that 2 * the border width is added to the GtkGrid widget at the bottom. Bizarre. Using GTK+ with 05aeaeef9ea41282a8859cbff2116d3fba5d31ea as the head.
Comment 1 Bastien Nocera 2011-08-26 10:46:38 UTC
Created attachment 194810 [details]
0 padding
Comment 2 Bastien Nocera 2011-08-26 10:46:55 UTC
Created attachment 194811 [details]
12 padding
Comment 3 Bastien Nocera 2011-08-26 10:47:14 UTC
Created attachment 194812 [details]
24 padding
Comment 4 Bastien Nocera 2011-08-26 10:48:09 UTC
Matthias, does this look like a GTK+ bug, or are we doing something weird?
Comment 5 Matthias Clasen 2011-08-26 12:50:23 UTC
Created attachment 194822 [details]
visible borders

Seems that at least the border of the panel itself is getting treated just fine.
The problem is the extra space inside the grid at the bottom.
Comment 6 Benjamin Otte (Company) 2011-08-26 14:58:08 UTC
Looks like a size request problem - we request too much space and then assign that space. (And because the grid still doesn't allocate extra space to children that don't expand it stays inside the grid.)

Now, why we do request too much space I have no idea. And there's quite a few ui files and custom widgetry involved in the control-center for me to quickly pinpoint the issue and come up with a ui file that reproduces the problem (I tried modifying wacom-properties.ui, but to no avail.

Bastien, could you or one of the control-center guys try yourself at that?
Comment 7 Matthias Clasen 2011-08-26 22:49:33 UTC
as a workaround, setting the border width on the grid instead of the ccpanel seems to work better.
Comment 8 Bastien Nocera 2011-08-27 11:28:19 UTC
That'll do me fine, unless somebody is interested in getting to the bottom of the problem.

commit 05ffef73479fd4a87b4693872631bc5faa9f70b8
Author: Bastien Nocera <hadess@hadess.net>
Date:   Sat Aug 27 12:27:02 2011 +0100

    wacom: Fix strange bottom padding
    
    Spotted by Matthias Clasen <mclasen@redhat.com>
    
    https://bugzilla.gnome.org/show_bug.cgi?id=657426