After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657257 - discoverer: retrieve audio track language from tags too
discoverer: retrieve audio track language from tags too
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-08-24 15:29 UTC by Vincent Penquerc'h
Modified: 2011-08-26 08:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
discoverer: retrieve audio track language from tags too (4.75 KB, patch)
2011-08-24 15:29 UTC, Vincent Penquerc'h 		needs-work Details | Review
discoverer: retrieve audio track language from tags too (4.74 KB, patch)
2011-08-25 08:39 UTC, Vincent Penquerc'h 		committed Details | Review

Description Vincent Penquerc'h 2011-08-24 15:29:57 UTC 
As I just did for subtitles
Comment 1 Vincent Penquerc'h 2011-08-24 15:29:59 UTC 
Created attachment 194625 [details] [review]
discoverer: retrieve audio track language from tags too
Comment 2 Sebastian Dröge (slomo) 2011-08-25 06:25:45 UTC 
Review of attachment 194625 [details] [review]:

::: gst-libs/gst/pbutils/gstdiscoverer.c
@@ +672,3 @@
+      if (gst_tag_list_get_string (((GstDiscovererStreamInfo *) info)->tags,
+              GST_TAG_LANGUAGE_CODE, &language)) {
+        info->language = g_strdup (language);

No need to copy the string, the return value of gst_tag_list_to_string() is owned by the caller
Comment 3 Vincent Penquerc'h 2011-08-25 08:39:39 UTC 
Created attachment 194680 [details] [review]
discoverer: retrieve audio track language from tags too

Fix leak found in review
Comment 4 Sebastian Dröge (slomo) 2011-08-26 08:07:37 UTC 
commit 921b92ce0603bb0341fabea5712f4b0da9a5f518
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Wed Aug 24 16:29:08 2011 +0100

    discoverer: retrieve audio track language from tags too
    
    https://bugzilla.gnome.org/show_bug.cgi?id=657257