After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657206 - GInputStream leaked in g_file_icon_load_async()
GInputStream leaked in g_file_icon_load_async()
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.29.x
Other All
: Normal major
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2011-08-23 22:47 UTC by Philip Withnall
Modified: 2011-08-24 06:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add a missing unref to g_file_icon_load_async() (851 bytes, patch)
2011-08-23 22:48 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2011-08-23 22:47:15 UTC 
There's a missing unref in load_async_callback() in gfileicon.c, which caused bug #656682.

Patch coming to fix this.
Comment 1 Philip Withnall 2011-08-23 22:48:58 UTC 
Created attachment 194535 [details] [review]
Add a missing unref to g_file_icon_load_async()
Comment 2 Matthias Clasen 2011-08-24 01:59:43 UTC 
Review of attachment 194535 [details] [review]:

Looks correct, please commit.
Comment 3 Philip Withnall 2011-08-24 06:56:13 UTC 
Comment on attachment 194535 [details] [review]
Add a missing unref to g_file_icon_load_async()

commit ff0cf7b681a2aac3b0f4b5608c8500db969ad4b7
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Tue Aug 23 23:47:54 2011 +0100

    Bug 657206 — GInputStream leaked in g_file_icon_load_async()
    
    Add a missing unref to g_file_icon_load_async().
    
    Closes: bgo#657206

 gio/gfileicon.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)