GNOME Bugzilla – Bug 657080
aacparse: failing test due to two buffers being dropped for one sync loss
Last modified: 2011-08-24 06:27:07 UTC
The aacparse test tries to feed a garbage frame in the middle of valid frames, and expects to receive an output buffer for each valid input buffer. The aacparse element wants two frames in a row to acquire sync, and ends up rejecting a valid frame, causing the aacparse test to come up one buffer short. Disabling the "need second buffer" test in aacparse causes the test to be happy. The straightforward fix would be to change the test to know it should expect one less buffer, but I'm wondering whether it's best to keep track in the aacparse element whehter we found sync once before, and, if so, resync on a single frame. This would mean a bit error would drop only the corrupt frame, and not a valid one as well.
Created attachment 194473 [details] [review] aacparse: only require two frames in a row when we do not have sync This avoids a single bit error dropping two frames unnecessarily. The two consecutive frames check is still required when we don't have sync.
commit f3fc3e1f69587e1bda5e628093918a2a3dd5f874 Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> Date: Tue Aug 23 12:12:15 2011 +0100 aacparse: only require two frames in a row when we do not have sync This avoids a single bit error dropping two frames unnecessarily. The two consecutive frames check is still required when we don't have sync. https://bugzilla.gnome.org/show_bug.cgi?id=657080