After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656988 - Screensaver inhibitor doesn't fall back to X11 codepath
Screensaver inhibitor doesn't fall back to X11 codepath
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Plugins
3.0.x
Other Linux
: Normal minor
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-08-21 01:25 UTC by Iain Nicol
Modified: 2011-09-05 13:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
scrsaver: Force gnome-session being present (988 bytes, patch)
2011-09-05 13:34 UTC, Bastien Nocera 		committed Details | Review

Description Iain Nicol 2011-08-21 01:25:03 UTC 
Running Totem 3.0.1 from within XFCE on Fedora 15.  GNOME is also installed.  XScreenSaver is not inhibited by Totem when totem is playing videos.

The following error message appears as of commit a1ed327b7522e884ed79dae4b7f4f57323adf365, but not before:

** (totem:29213): WARNING **: Problem inhibiting the screensaver: GDBus.Error:org.freedesktop.DBus.Error.NameHasNoOwner: Name "org.gnome.SessionManager" does not exist

As of the above commit, totem is not checking for a dbus name owner.  priv->have_session_dbus is always getting set to true in screensaver_dbus_proxy_new_cb.  Totem now always uses the fact that this variable is true to decide to go down the primary dbus codepath for inhibiting, and never down the fallback X11 path.  This leads to that warning in on_inhibit_cb.
Comment 1 Bastien Nocera 2011-09-05 13:34:57 UTC 
Created attachment 195697 [details] [review]
scrsaver: Force gnome-session being present

If gnome-session isn't present, we should error out earlier.
Comment 2 Bastien Nocera 2011-09-05 13:36:17 UTC 
The problem actually is that I wouldn't expect to have a GDBusProxy at all if gnome-session wasn't present. The attached patch should make it error out in screensaver_dbus_proxy_new_cb() as expected. Could you please check?
Comment 3 Bastien Nocera 2011-09-05 13:44:36 UTC 
Please reopen if it doesn't fix the problem

Attachment 195697 [details] pushed as b568b23 - scrsaver: Force gnome-session being present