After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656473 - Store server folder cache in user's cache directory
Store server folder cache in user's cache directory
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
3.0.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2011-08-13 19:34 UTC by Allison Karlitskaya (desrt)
Modified: 2011-09-26 10:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
eds patch (34.12 KB, patch)
2011-09-22 10:12 UTC, Milan Crha
committed Details | Review
evo patch (1.49 KB, patch)
2011-09-22 10:13 UTC, Milan Crha
committed Details | Review
eex patch (3.08 KB, patch)
2011-09-22 10:15 UTC, Milan Crha
committed Details | Review
ema patch (5.79 KB, patch)
2011-09-22 10:16 UTC, Milan Crha
committed Details | Review

Description Allison Karlitskaya (desrt) 2011-08-13 19:34:16 UTC
Evolution downloads hundreds of megs of cached message content and dumps them into ~/.local/share/evolution.  Then these messages get sucked into my workstation backups.  I already have backups done on the server.

If they were in ~/.cache/ then they would not be backed up.
Comment 1 Milan Crha 2011-09-22 10:02:14 UTC
Confirming. For example NNTP will use both user's data dir and cache dir, because the backup should contain list of subscribed folders, but messages itself are not that important. On the other hand, if user wishes to copy content locally for offline, then he/she might miss the information in the backup file. Maybe. Anyway, I agree that for providers which have all data stored on the server is better to save local cache into user's cache directory.
Comment 2 Milan Crha 2011-09-22 10:12:18 UTC
Created attachment 197226 [details] [review]
eds patch

for evolution-data-server;

Involves API changes and using of the API for imap, imapx and nntp providers.
Comment 3 Milan Crha 2011-09-22 10:13:30 UTC
Created attachment 197227 [details] [review]
evo patch

for evolution;

Initialize CamelSession's user-cache-dir on creation too.
Comment 4 Milan Crha 2011-09-22 10:15:00 UTC
Created attachment 197228 [details] [review]
eex patch

for evolution-exchange;

Use the cache dir in eex as well...
Comment 5 Milan Crha 2011-09-22 10:16:53 UTC
Created attachment 197229 [details] [review]
ema patch

for evolution-mapi;

... same as in ema.
Comment 6 Matthew Barnes 2011-09-22 14:12:28 UTC
Looks awesome!

I wonder if it would be worth also adding a migrate_files() method to CamelServiceClass to be called during service_construct(), so providers have a more formal hook to use for migration tasks both now and in the future.  Might also prove beneficial to have more centralized control over when file migration occurs.  It has in Evolution, at least.
Comment 7 Milan Crha 2011-09-26 10:16:07 UTC
Created commit baabf6b in eds master (3.3.1+)
Created commit f579563 in evo master (3.3.1+)
Created commit 13201f8 in eex master (3.3.1+)
Created commit 5c8a2be in ema master (3.3.1+)