After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656374 - ShellApp: Use a proper timestamp in shell_app_activate
ShellApp: Use a proper timestamp in shell_app_activate
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-08-12 03:21 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2011-08-12 07:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ShellApp: Use a proper timestamp in shell_app_activate (916 bytes, patch)
2011-08-12 03:21 UTC, Jasper St. Pierre (not reading bugmail) 		reviewed Details | Review
ShellApp: Make sure that we use a valid timestamp when activating (1.39 KB, patch)
2011-08-12 07:23 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2011-08-12 03:21:08 UTC 
This fixes a bunch of incorrect "Window needs attention" notifications
when trying to switch applications in the overview.
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-08-12 03:21:11 UTC 
Created attachment 193671 [details] [review]
ShellApp: Use a proper timestamp in shell_app_activate

Otherwise, we'd be comparing against the last_used_time and setting
it to 0.
Comment 2 Colin Walters 2011-08-12 07:18:55 UTC 
Review of attachment 193671 [details] [review]:

This is OK, though I think it'd be better to do:

  if (timestamp == 0)
    timestamp = shell_global_get_current_time (global);

inside shell_app_activate_full().
Comment 3 Jasper St. Pierre (not reading bugmail) 2011-08-12 07:23:13 UTC 
Created attachment 193674 [details] [review]
ShellApp: Make sure that we use a valid timestamp when activating

Otherwise, we'd be comparing against the last_used_time and setting
it to 0.



This better?
Comment 4 Colin Walters 2011-08-12 07:28:05 UTC 
Review of attachment 193674 [details] [review]:

Looks good.
Comment 5 Jasper St. Pierre (not reading bugmail) 2011-08-12 07:30:36 UTC 
Attachment 193674 [details] pushed as 91cba1f - ShellApp: Make sure that we use a valid timestamp when activating