Created attachment 193497 [details] [review]
proposed patch

(originally filed as https://bugzilla.redhat.com/show_bug.cgi?id=599055)

The motivation is to have consistent behaviour on crypto volumes and records in fstab. Basically if we filter certain mounts out (simply for their mountpoint being in /mnt for example) but still present corresponding volumes, bad things would happen. This patch is based on assumption from existing code that crypto volumes should be always visible.

Not sure if this is the experience we want, system mounts should be hidden no matter if they're crypto or not. But it's difficult to distinguish system mounts from user ones (and match against fstab) when we are not unlocked yet.


My test case is as follows (yes, it's rather silly):
 1. have a fstab record on /dev/dm-0 mounting in /mnt/test
 2. create a crypto partition on USB stick
 3. check Nautilus sidebar, the crypto volume is shown
 4. click it, enter password to unlock
 5. an error dialog would show up saying either that /dev/dm-0 is already mounted (2nd try) or nothing would happen at all (first try)
 6. /dev/mapper/udisks-luks-uuid-e5a3a451-e26e-4cc4-a4fd-f5b0aeef1546-uid710 will be mounted (check `mount`); it's basically a symlink to '../dm-0', thus matching the fstab entry

Another test case:
 1. create a /home crypto partition, let it unlock and mount on boot
 2. start Gnome, check Nautilus sidebar