After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656175 - Antlr's PRETTY_LABELS should exist in libcaribou
Antlr's PRETTY_LABELS should exist in libcaribou
Status: RESOLVED FIXED
Product: caribou
Classification: Applications
Component: default
git master
Other Linux
: Normal normal
: ---
Assigned To: caribou-maint
caribou-maint
Depends on:
Blocks:
 
 
Reported: 2011-08-08 19:32 UTC by Dan Winship
Modified: 2012-11-02 12:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Port label string construction code to libcaribou (4.92 KB, patch)
2012-10-30 09:10 UTC, Daiki Ueno 		committed Details | Review

Description Dan Winship 2011-08-08 19:32:26 UTC 
The shell keyboard copies PRETTY_LABELS from Antlr... we should move this into libcaribou instead. Probably a "label" property on Caribou.KeyModel?

Where should KeyModel get the label from? It seems like it would make the most sense to add it as a property to the layout files... (Then layout files that needed additional pretty labels could just add them there.)

I'll write the patches if that sounds right.
Comment 1 Daiki Ueno 2012-10-30 09:10:26 UTC 
Created attachment 227616 [details] [review]
Port label string construction code to libcaribou

Move the key label construction code from Antler to libcaribou and
also handle the "text" attribute of key.
--
This is also needed for the text-generating keys (bug 687026).
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-10-30 11:52:54 UTC 
Review of attachment 227616 [details] [review]:

Look good to me, probably next step would be contact gnome-shell developers, as in comment 0 Dan Winship mentions that right now they just have a C&P version of all the stuff moved to the library.
Comment 3 Daiki Ueno 2012-10-31 01:04:17 UTC 
Comment on attachment 227616 [details] [review]
Port label string construction code to libcaribou

Thanks for the review, committed with an off-by-one fix.
I'll file a bug againt gnome-shell to use KeyModel.label soon.

Attachment 227616 [details] pushed as 6c46656 - Port label string construction code to libcaribou