After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656151 - configure test logic inverted, doesn't match comments
configure test logic inverted, doesn't match comments
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
2.29.x
Other Solaris
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2011-08-08 10:35 UTC by declanw
Modified: 2011-08-22 16:28 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description declanw 2011-08-08 10:35:19 UTC
configure.ac has the following:

   # on solaris and irix, statfs doesn't even have the f_bavail field
   AS_IF([test $ac_cv_member_struct_statfs_f_bavail = yes],
      [ac_cv_func_statfs=no],
   # else, at least on linux, statfs is the actual syscall
      [ac_cv_func_statvfs=no])

If $ac_cv_member_struct_statfs_f_bavail is no, it disables statvfs, which is the one it should be enabling. 
Also I think the x = x test armour is missing.
Comment 1 Patrick Welche 2011-08-22 16:28:33 UTC
This was noted over in Bug 617949 - any chance the rest of the patch in that bug can be commited too?