After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656097 - Empathy should show an informative text inside the contact list when no contacts are online
Empathy should show an informative text inside the contact list when no conta...
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Contact List
unspecified
Other Linux
: Normal enhancement
: 3.4
Assigned To: empathy-maint
Depends on:
Blocks: 658858
 
 
Reported: 2011-08-07 09:22 UTC by ahatomastarday
Modified: 2012-08-20 16:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
make code displaying the 'no match found' page more generic (2.69 KB, patch)
2012-02-02 16:01 UTC, Guillaume Desmottes
committed Details | Review
add generic contact icon and account settings button to the message page (5.71 KB, patch)
2012-02-02 16:01 UTC, Guillaume Desmottes
committed Details | Review
display a specific message if no account is configured (1.93 KB, patch)
2012-02-02 16:02 UTC, Guillaume Desmottes
committed Details | Review
display a message if accounts need to be enabled (3.38 KB, patch)
2012-02-02 16:02 UTC, Guillaume Desmottes
committed Details | Review
individual-manager: add API to know when contacts have been loaded from folks (3.60 KB, patch)
2012-02-06 13:20 UTC, Guillaume Desmottes
committed Details | Review
Display a spinner while loading contacts from Folks (7.75 KB, patch)
2012-02-06 13:20 UTC, Guillaume Desmottes
committed Details | Review

Description ahatomastarday 2011-08-07 09:22:02 UTC
Currently, when none of your contacts are online, Empathy shows an empty contact list. I can tell from experience that this is somehow confusing to some users, who either don't understand why the contact list is empty or even wonder what is that empty rectangle, since there's no indication that it is a contact list (this happens if none of their contacts are online when they try Empathy for the first time).

I think the contact list should display some sort of informative text, telling the user that there are no online contacts at the moment, rather than showing just an empty space.

A message should be displayed in the contact list as well if the user haven't configured any account yet or if all of them are deactivated.
Comment 1 Guillaume Desmottes 2011-08-15 06:32:08 UTC
Agreed. There are different cases to consider:

- online, no online contact but offline contacts
- online, no online contact and no offline contacts
- offline, no account configured or enabled


We should probably add some buttons to display offline contacts or open the accounts dialog as well.
Comment 2 Guillaume Desmottes 2011-08-22 11:14:39 UTC
We could display something when all the accounts are connecting as well.
Comment 3 Nick Richards 2011-08-22 15:19:50 UTC
I've added designs to cover all of this to the latest wireframes at :

http://nickr.org/linux/wireframes/empathy-video-chat-wireframes.pdf

it's pages 21-23 of the 22nd August 2011 version.
Comment 4 Guillaume Desmottes 2011-09-06 07:43:35 UTC
We are past UI freeze so that probably won't make it for 3.2.
Comment 5 Allan Day 2012-01-27 11:27:56 UTC
We're doing something similar in GNOME Contacts. This is the current design:

https://github.com/gnome-design-team/gnome-mockups/raw/master/contacts/png/no-contacts.png

This is almost identical to Nick's wireframes. The key thing is to have a button that provides access to the account settings.
Comment 6 Nick Richards 2012-02-02 13:37:22 UTC
http://nickr.org/linux/wireframes/empathy-wireframes.pdf is the latest
Comment 7 Guillaume Desmottes 2012-02-02 14:11:23 UTC
(In reply to comment #6)
> http://nickr.org/linux/wireframes/empathy-wireframes.pdf is the latest

Page 35 does the "loading state" also apply when connecting accounts?
There are 2 cases here:
- Empathy starts and needs to connect accounts
- Empathy starts and accounts are already connected. Unfortunatelly, it still takes a bunch of time to fetch all the contacts.
Comment 8 Guillaume Desmottes 2012-02-02 16:01:53 UTC
Created attachment 206643 [details] [review]
make code displaying the 'no match found' page more generic
Comment 9 Guillaume Desmottes 2012-02-02 16:01:57 UTC
Created attachment 206644 [details] [review]
add generic contact icon and account settings button to the message page
Comment 10 Guillaume Desmottes 2012-02-02 16:02:00 UTC
Created attachment 206645 [details] [review]
display a specific message if no account is configured
Comment 11 Guillaume Desmottes 2012-02-02 16:02:04 UTC
Created attachment 206646 [details] [review]
display a message if accounts need to be enabled
Comment 12 Guillaume Desmottes 2012-02-02 16:03:52 UTC
Those patches implement the first screen from the mockups: no account and no account enabled.
Comment 13 Xavier Claessens 2012-02-03 11:55:51 UTC
Looks all good, +1
Comment 14 Guillaume Desmottes 2012-02-03 11:58:13 UTC
Attachment 206643 [details] pushed as c1adae1 - make code displaying the 'no match found' page more generic
Attachment 206644 [details] pushed as 808aab1 - add generic contact icon and account settings button to the message page
Attachment 206645 [details] pushed as df8e44c - display a specific message if no account is configured
Attachment 206646 [details] pushed as 42993a4 - display a message if accounts need to be enabled
Comment 15 Guillaume Desmottes 2012-02-06 13:20:45 UTC
Created attachment 206879 [details] [review]
individual-manager: add API to know when contacts have been loaded from folks
Comment 16 Guillaume Desmottes 2012-02-06 13:20:49 UTC
Created attachment 206880 [details] [review]
Display a spinner while loading contacts from Folks
Comment 17 Nick Richards 2012-02-14 09:23:38 UTC
The loading state should ideally be shown at *any* time that contacts are being loaded (i.e. it's at the bottom of the list and if you have a load of accounts online it'll be off the screen - that's by design).
Comment 18 Guillaume Desmottes 2012-02-14 09:35:02 UTC
Attachment 206879 [details] pushed as 6ef0203 - individual-manager: add API to know when contacts have been loaded from folks
Attachment 206880 [details] pushed as c2e2697 - Display a spinner while loading contacts from Folks
Comment 19 Guillaume Desmottes 2012-02-14 09:38:31 UTC
I opened bug #670044 for the remaining bits.
Comment 20 Xavier Claessens 2012-08-20 10:19:05 UTC
To fix bug #658858 I tested what happens if I have only offline contacts. Unfortunately the roster is shown empty with no message.

That case should have been covered by this bug (or it regressed?).
Comment 21 Xavier Claessens 2012-08-20 16:02:42 UTC
(In reply to comment #20)
> To fix bug #658858 I tested what happens if I have only offline contacts.
> Unfortunately the roster is shown empty with no message.
> 
> That case should have been covered by this bug (or it regressed?).

fixed with commit 547c7e8d49b1e7a6ce0c77fc2b002c64f02fb1d5
Comment 22 Allan Day 2012-08-20 16:05:35 UTC
Fantastic, thanks Xavier!