Created attachment 193260 [details] [review]
Auto-load OSK GTK+ modules when OSK is enabled

We don't have a GTK+ module yet, is this for the IM modules? For a future GTK+ module?

This is for Nohemi and Dan's OSK work.

Note that this would need more work as tweaking the gsettings key right now would start both Caribou and load up the GTK+ module under gnome-shell.

In any case, something like this will be needed soon, so best handle it all in one location.

Created attachment 196736 [details] [review]
Auto-load OSK GTK+ modules when OSK is enabled

fix module name

Created attachment 196738 [details] [review]
module: fix module loading/unloading

Force the module to stay resident after being loaded (otherwise it
will crash if it's loaded, unloaded, and loaded again, because it will
fail to register its types the second time).

Also fix a few bugs in the unload() function, even though it is no
longer used at this point. To be fixed for 3.4.

----

Originally I wrote a patch to make this track the gsettings key, so it
could disable itself when the keyboard was disabled even though it
wasn't getting unloaded. But that had no effect, since atk-bridge
wasn't getting unloaded either, so we were still getting events from
that. So... we can fix this in 3.4.

(Also, it only matters for fallback mode, since gnome-shell won't show
the keyboard if the setting is disabled anyway.)

I am a bit confused, how will caribou be used in GNOME Shell? Through the caribou daemon (that taps in to AT-SPI), or this module?

With this patch, when you enable the keyboard in the control panel or the shell a11y menu, then caribou-gtk-module and atk-bridge will both be loaded into all gtk apps, and the caribou daemon will be started. If the shell is running, then it will provide its keyboard, and if the user is in fallback mode, then caribou will cause antler to be started. Either way, the keyboard will be receiving notifications from both caribou-gtk-module and the caribou daemon.

It's possible that we don't really need caribou-gtk-module at this point I guess... (my earlier problems with running with a11y enabled turned out to be because of some bad old preferences causing a mix of corba and dbus a11y stuff to be run). I haven't tested that though...

Are both patches non-obsolete? In any case, I trust you. Please commit.

Attachment 196736 [details] pushed as 524b704 - Auto-load OSK GTK+ modules when OSK is enabled
Attachment 196738 [details] pushed as 14ce9ba - module: fix module loading/unloading