After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655866 - jackaudiosink: Don't call g_alloca in jack_process_cb
jackaudiosink: Don't call g_alloca in jack_process_cb
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-08-03 02:04 UTC by Tristan Matthews
Modified: 2011-08-03 07:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix for 655866 (3.13 KB, patch)
2011-08-03 02:07 UTC, Tristan Matthews 		committed Details | Review

Description Tristan Matthews 2011-08-03 02:04:03 UTC 
g_alloca is not an RT-safe function, therefore it should not be called inside the jack_process_cb function. It is used to allocate pointers for samples. These pointers can be allocated in advance as is already the case in the jackaudiosrc plugin, in the gst_jack_audio_sink_allocate_channels function.
Comment 1 Tristan Matthews 2011-08-03 02:07:57 UTC 
Created attachment 193121 [details] [review]
Fix for 655866
Comment 2 Sebastian Dröge (slomo) 2011-08-03 07:45:19 UTC 
commit c26442a3bae0f93947f7dc4f858b968a254842ee
Author: Tristan Matthews <tristan@sat.qc.ca>
Date:   Tue Aug 2 22:05:08 2011 -0400

    jackaudiosink: Don't call g_alloca() in process_cb
    
    g_alloca() is not RT-safe, so instead we should allocate the
    memory needed in advance. Fixes #655866