GNOME Bugzilla – Bug 655858
gtk3 fallout
Last modified: 2012-09-29 20:47:11 UTC
In file included from ../../src/wbc-gtk.h:8:0, from gnm-solver.h:8, from gnm-solver.c:10: ../../src/widgets/gnumeric-expr-entry.h:72:10: error: expected declaration specifiers or ‘...’ before ‘GtkUpdateType’
never mind comment 1. keeping open because there surely is fallout.
All toolbars are broken for me. I see a drop-down button, but the rest is grey and empty. If I browse the menu by clicking on the drop-down button, certain actions fire unprovoked -- such as font size and font name.
toolbars should be fixed now. So is the warning spew when opening the manage-sheet dialog
A pretty serious issue is that clicking on the sheet tab freezes Gnumeric.
I have previously seen the unprovoked firing of toolbar items that ended up in the menu but I can't find the bug report nor can I replicate it.
Created attachment 193120 [details] Broken toolbars The toolbars I see.
My toolbars are perfectly fine...
Clicking on the sheet tab doesn't freeze for me anymore (but editing the label is also disabled).
Hmm, your picture of your toolbars doesn't show the toolbar drag region either. Is there a preference to show the drag regions of toolbars?
some widgets in the toolbars probably have size issues.
Created attachment 193126 [details] The toolbars are just fine for me. Something else must be going on since for me the toolbars look fine.
They look fine for me too, but we don't use the same theme, which might explain the difference.
Hmm, I was wrong, they don't look fine anymore after updating. Some recent change broke things for me.
Morten, your toolbars should work if you turn on the /desktop/gnome/interface/toolbar-detachable gconf key.
The toolbars issue should be fixed now, please check. Another pending issue is that GnmNotebook grows so that all tabs are visible, try with samples/chart-tests.gnumeric
toolbars confirmed fixed for me.
something happened to the about dialog...
Regarding the growing of GnmNotebook so that all tabs are visible: if you change the slider to force scolling than adding more sheets does not enlarge the notebook anymore.
GnmNotebook and dialog-about fixed.
Pressing the open-file button gives me about 20 of these: (/home/welinder/gnome-src/gnumeric/src/.libs/gnumeric:13215): GLib-GObject-WARNING **: gsignal.c:2275: signal `deactivate' is invalid for instance `0x11ebd60'
'deactivate' signal removed.
GnmNotebook does not seem to be fixed: new gnumeric add a sheet the gnumeric window just increased in width. That should not happen!
Also the status region (to the right of the tabs) does not show status updates.
new gnumeric start typing =n the tooltip appears at the wrong location. It should be below the entrybox.
Editing of the tab label can now be ended by a mouse click. We are nearly at the state as before the gtk3 transition except: We do not recognize that the mouse click was in the widget and so also stop editing if the user clicks in the widget while editing.
Created attachment 193429 [details] screen shot showing autofilter combo The autofilter combos are much too large!
The layout of the top-10 autofilter dialog is messed up.
Not only that, autofilter combo is not correctly positioned and does not resize on zooming.
The autofilter combo never used to resize on zooming (and I am not even sure that it should)
If they don't resize, they can have the correct size for only one zoom level, weird.
Whenever I open the _second_ file (any second file) in Gnuemric, I get a large number of (gnumeric:24326): Gtk-WARNING **: gtk_widget_size_allocate(): attempt to allocate widget with width 31 and height -5
A back trace for (gnumeric:24326): Gtk-WARNING **: gtk_widget_size_allocate(): attempt to allocate widget with width 31 and height -5 Breakpoint 1, 0xb726af34 in g_log () from /lib/i386-linux-gnu/libglib-2.0.so.0 (gdb) bt
+ Trace 228046
I can't reproduce that, which gtk+ version? I have 3.0.12
I am using gtk 3.0.8. Note that these warnings occur for me when opening the second file from within Gnumeric.
I opened up to 4 files from within gnumeric and get no warning at all.
Hmm, the zoom dialog barely fits onto my monitor.
zoom dialog fixed.
GnmNotebook styling fixed. (This is distinct from the paned sizing code which is still broken and disconnected.)
The page setup dialog is badly broken. Selecting File->Pagesetup results in "Unknown internal child: entry" and no dialog.
Don't know what happened with page setup dialog. Just opened tue ui file with glade and saved, and things work again.
hmm, in the pagesetup dialog: alignment issue with the orientation buttons, spacing with the scale buttons, extra space on the top of the header/footer page and sheet page, spacing of items on pagearea page. Probably easily fixed but if I do that we have Gtk[VH]Box back.
function tooltip location fixed
On a sheet where negative numbers are in red, I am seeing non-negative numbers sometimes turn red too. I'll see if I can create a small sample.
Sticky-red formats problem fixed in goffice.
Created attachment 193768 [details] The way sheet tabs are currently displayed I could display the backgound colors with a hack (setting the state to active when drawing), but this is not a solution. The issue is that if the theme uses an image as background (here a gradient), gtk_widget_overide_bakcground_color has no effect. This is a gtk bug IMHO, but they might consider it a feature.
Filed #656461 for the override_background_color issue.
The sheet resize dialog has spacing issues and the dialog grows as the column or row numbers are enlarged.
Either I can't reproduce the resize dialog issues or I'm not looking at the right place. Can you provide screenshots?
Created attachment 194192 [details] screenshot of the size dialog By default I use 128 rows and columns. When I increase the number of rows the dialog becomes wider (as the number takes up more space).
Please try again. Not sure it's fixed.
The spacing is much better. The dialog still grows slightly and the words "Rows" "Columns" jump forth and back as the length of the numbers changes. Any stationary screen shot looks good though! :-)
I investigated the autofilter combo size issue. The problem is that GtkWidgets can't anymore be shrinked (a new feature!), and the minimum height for this widget seems to be 25 pixels (for me) while we require less than that. Analog issues occur with sheet widgets, they can't be made lower than what gtk+ wants, so they often extend outside of the requested area. Btw, it would be sane to not add a lot more comments to this bug, if new issues are found, I believe it's better to open new bugs and make this one depends on them.
(In reply to comment #26) > Created an attachment (id=193429) [details] > screen shot showing autofilter combo > > The autofilter combos are much too large! This is now fixed.
I think we're done here. If not, please file separate bugs for open issues of this nature.