GNOME Bugzilla – Bug 655619
Error pages shouldn't be stored in history
Last modified: 2012-08-14 09:47:31 UTC
When a page can't be loaded, it shouldn't be stored in history. Otherwise you end with lots of typos in the browsing history. This seems easy on a first check
*** Bug 356778 has been marked as a duplicate of this bug. ***
This is easy with EPHY_PAGE_VISIT_* in ephy-web-view. I am wondering though if we should handle this in history-service. Perhaps a new type of visit? or ignore this kind of visit in the service. I wonder if it is better to have the decision behind the history API or in ephy-web-view.
Created attachment 211275 [details] [review] Don't restore zoom level and mark visits for error pages Introduce a new page visit value for error pages and set it when necessary. This makes it possible to avoid restoring zoom level and marking visit for these pages, meaning sites that have failed to load are not leaked into the history database.
(In reply to comment #3) > Created an attachment (id=211275) [details] [review] > Don't restore zoom level and mark visits for error pages > > Introduce a new page visit value for error pages and set it when > necessary. This makes it possible to avoid restoring zoom level > and marking visit for these pages, meaning sites that have failed > to load are not leaked into the history database. Hum, shouldn't we just not store anything at all for error pages in the DB?
Comment on attachment 211275 [details] [review] Don't restore zoom level and mark visits for error pages Yes, I think we shouldn't store erroneous pages in the history.
Created attachment 221112 [details] [review] Do not store error pages in history
Comment on attachment 221112 [details] [review] Do not store error pages in history Pushed to master ad4b199dc292
Closing.