After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655574 - ogg: crash determining duration of empty vorbis packet
ogg: crash determining duration of empty vorbis packet
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal critical
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-07-29 12:16 UTC by Jonathan Liu
Modified: 2011-08-03 09:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix crash when determining duration of empty vorbis packet (521 bytes, patch)
2011-07-29 12:16 UTC, Jonathan Liu 		committed Details | Review

Description Jonathan Liu 2011-07-29 12:16:08 UTC 
Created attachment 192869 [details] [review]
Fix crash when determining duration of empty vorbis packet

In packet_duration_vorbis (ext/ogg/gstoggstream.c), the packet data is dereferenced without checking if the packet is 0 bytes. This causes a crash.
Comment 1 Sebastian Dröge (slomo) 2011-08-03 08:19:23 UTC 
commit 8bd3bdaf3768b3fb6adc85b3bc681fdce07b786e
Author: Jonathan Liu <net147@gmail.com>
Date:   Wed Aug 3 10:18:29 2011 +0200

    oggstream: Fix crashes with 0-byte vorbis packets
    
    Fixes bug #655574.