After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655479 - gjs needs a non-automagic way of choosing the javascript package to build against
gjs needs a non-automagic way of choosing the javascript package to build aga...
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
1.29.x
Other Linux
: Normal enhancement
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2011-07-28 08:02 UTC by Alexandre Rostovtsev
Modified: 2011-07-28 20:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make choice of javascript package non-automagic (4.83 KB, patch)
2011-07-28 08:06 UTC, Alexandre Rostovtsev 		committed Details | Review

Description Alexandre Rostovtsev 2011-07-28 08:02:41 UTC 
gjs-1.29.15 picks the javascript package to build against automagically: it looks for mozjs185, and if it's not found, looks for mozilla-js. While this behavior is certainly user-friendly, it makes it impossible to build a gjs package that links to xulrunner on a machine that happens to have spidermonkey installed.
Comment 1 Alexandre Rostovtsev 2011-07-28 08:06:32 UTC 
Created attachment 192799 [details] [review]
Make choice of javascript package non-automagic

This patch adds a --with-js-package configure flag to allow selecting which javascript package to build against, e.g. to force building against xulrunner on a system that happens to have spidermonkey installed.

By default, the behavior is the same as before (first check for mozjs185, then for mozilla-js).
Comment 2 Colin Walters 2011-07-28 20:34:22 UTC 
Review of attachment 192799 [details] [review]:

Thanks so much for the patch, Alexandre!  I just tweaked your commit message to follow our standard bugzilla linking style.
Comment 3 Colin Walters 2011-07-28 20:34:33 UTC 
Attachment 192799 [details] pushed as 2b16f01 - Make choice of javascript package non-automagic