After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655422 - Text box theming
Text box theming
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-07-27 13:59 UTC by Allan Day
Modified: 2011-08-03 11:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Comparison between screenshot and mockup (114.11 KB, image/png)
2011-07-27 13:59 UTC, Allan Day 		  Details
polkit: Update style of password entry (1.03 KB, patch)
2011-07-27 14:56 UTC, Florian Müllner 		accepted-commit_now Details | Review
polkit: Update style of password entry (1.03 KB, patch)
2011-07-30 13:00 UTC, Florian Müllner 		committed Details | Review

Description Allan Day 2011-07-27 13:59:34 UTC 
Created attachment 192753 [details]
Comparison between screenshot and mockup

Currently, text boxes have a flat white fill and no stroke. Also, they don't react on focus.

The mockups include details on how these widgets should appear - their fill should have a gradient, and their stroke should change colour when they are focused. See, for example:

http://git.gnome.org/browse/gnome-shell-design/plain/mockups/static/unlock-prompt.png

I've attached a comparison of the current state and the design. I can provide other details on the design if they are required.
Comment 1 Florian Müllner 2011-07-27 14:56:27 UTC 
Created attachment 192758 [details] [review]
polkit: Update style of password entry

Use a subtle gradient background and add a blue border when focused.
Comment 2 drago01 2011-07-27 21:47:33 UTC 
Review of attachment 192758 [details] [review]:

Looks good.
Comment 3 Allan Day 2011-07-30 12:15:01 UTC 
It needs a softer blue; #3465a4 is what is used in the mockups.
Comment 4 Florian Müllner 2011-07-30 13:00:37 UTC 
Created attachment 192907 [details] [review]
polkit: Update style of password entry

(In reply to comment #3)
> It needs a softer blue; #3465a4 is what is used in the mockups.

Sure.
Comment 5 Florian Müllner 2011-08-03 11:06:44 UTC 
Attachment 192907 [details] pushed as 3fd90df - polkit: Update style of password entry

Pushed with some color adjustments requested by Allan on IRC - no changes in the affected properties with regard to the approved version, so not going through re-review.