GNOME Bugzilla – Bug 654972
[rtmpsrc] "permission denied" error from rtmp not recognized
Last modified: 2018-11-03 13:08:08 UTC
when requesting a resource which the rtmp server denies access to, this error is not in any way detected, instead the source keeps polling for data and will keep doing that forever.
Created attachment 192310 [details] [review] [rtmpsrc] add connection timeout property this doesn't solve the whole issue but at least it'll timeout now throwing EOS if the server denies permission to a resource. i need to do some more research in the librtmp because right now i have no clue how to obtain detail about connection errors or if it's even possible at all.
Looks like a real bug. We're starting to add timeout properties to a lot of BaseSrc elements. Developers, shall we move "timeout" to BaseSrc?
Review of attachment 192310 [details] [review]: The patch is pretty obvious but I'd go without the whitespace changes. ::: ext/rtmp/gstrtmpsrc.h @@ +35,1 @@ G_BEGIN_DECLS No need to change whitespace. @@ +44,3 @@ #define GST_IS_RTMP_SRC_CLASS(klass) \ (G_TYPE_CHECK_CLASS_TYPE((klass),GST_TYPE_RTMP_SRC)) +typedef struct _GstRTMPSrc GstRTMPSrc; No need to change whitespace. @@ +58,1 @@ /* < private > */ No need to change whitespace. @@ +73,3 @@ struct _GstRTMPSrcClass { + GstPushSrcClass parent; No need to change whitespace. @@ +80,1 @@ G_END_DECLS No need to change whitespace. @@ +81,1 @@ #endif /* __GST_RTMP_SRC_H__ */ No need to change whitespace.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/42.