After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654917 - Make g_cclosure_marshal_generic the default signal handler
Make g_cclosure_marshal_generic the default signal handler
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gobject
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2011-07-19 17:16 UTC by Johan (not receiving bugmail) Dahlin
Modified: 2011-07-19 17:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use a generic marshaller if one is not specified (893 bytes, patch)
2011-07-19 17:16 UTC, Johan (not receiving bugmail) Dahlin 		reviewed Details | Review
Pass in NULL instead of g_cclosure_marshal_generic (13.83 KB, patch)
2011-07-19 17:16 UTC, Johan (not receiving bugmail) Dahlin 		none Details | Review
Pass in NULL instead of g_cclosure_marshal_generic (13.36 KB, patch)
2011-07-19 17:19 UTC, Johan (not receiving bugmail) Dahlin 		committed Details | Review
Use a generic marshaller if one is not specified (4.80 KB, patch)
2011-07-19 17:38 UTC, Johan (not receiving bugmail) Dahlin 		committed Details | Review

Description Johan (not receiving bugmail) Dahlin 2011-07-19 17:16:52 UTC 
Use g_cclosure_marshal_generic as the default signal handler isn't
especified to g_signal_new and its variants.

Also attaches a patch to gobject/gio which takes advantage of that patch
internally.
Comment 1 Johan (not receiving bugmail) Dahlin 2011-07-19 17:16:55 UTC 
Created attachment 192253 [details] [review]
Use a generic marshaller if one is not specified

Since g_cclosure_marshal_generic is always enabled, it makes
sense to always use that instead of using generated ones.
Comment 2 Johan (not receiving bugmail) Dahlin 2011-07-19 17:16:58 UTC 
Created attachment 192254 [details] [review]
Pass in NULL instead of g_cclosure_marshal_generic

NULL is now a shortcut for g_cclosure_marshal_generic, so avoid
referencing it directly.
Comment 3 Johan (not receiving bugmail) Dahlin 2011-07-19 17:19:33 UTC 
Created attachment 192255 [details] [review]
Pass in NULL instead of g_cclosure_marshal_generic

NULL is now a shortcut for g_cclosure_marshal_generic, so avoid
referencing it directly.
Comment 4 Colin Walters 2011-07-19 17:31:08 UTC 
Review of attachment 192253 [details] [review]:

::: gobject/gsignal.c
@@ +1631,3 @@
     node->accumulator = NULL;
+  if (c_marshaller == NULL)
+      c_marshaller = g_cclosure_marshal_generic;

The documentation should be updated for this.
Comment 5 Colin Walters 2011-07-19 17:31:27 UTC 
Review of attachment 192255 [details] [review]:

Looks obviously fine.
Comment 6 Johan (not receiving bugmail) Dahlin 2011-07-19 17:38:02 UTC 
Created attachment 192256 [details] [review]
Use a generic marshaller if one is not specified

Since g_cclosure_marshal_generic is always enabled, it makes
sense to always use that instead of using generated ones.
Comment 7 Johan (not receiving bugmail) Dahlin 2011-07-19 17:39:39 UTC 
Attachment 192255 [details] pushed as ec98953 - Pass in NULL instead of g_cclosure_marshal_generic
Attachment 192256 [details] pushed as fa2861e - Use a generic marshaller if one is not specified