After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654865 - Concatenating strings
Concatenating strings
Status: RESOLVED FIXED
Product: tomboy
Classification: Applications
Component: General
unspecified
Other All
: Normal minor
: ---
Assigned To: Aaron D Borden
Tomboy Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-07-18 18:30 UTC by Marek Černocký
Modified: 2011-08-20 21:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixes the string. (1.03 KB, patch)
2011-07-18 23:21 UTC, Aaron D Borden 		committed Details | Review

Description Marek Černocký 2011-07-18 18:30:04 UTC 
Construction
Catalog.GetString ("Create destination folder for " +  export_type_name + " Export")
in Tomboy/ExportAllAplicationAddin.cs is not good. Some languages require different words order.

Better way is:
String.Format (Catalog.GetString ("Create destination folder for {0} Export"), export_type_name)
Comment 1 Aaron D Borden 2011-07-18 23:21:19 UTC 
Created attachment 192222 [details] [review]
Fixes the string.

Missed this in code review, thanks for bringing it up.
Comment 2 Sandy Armstrong 2011-08-06 05:49:02 UTC 
Review of attachment 192222 [details] [review]:

Cool.
Comment 3 Aaron D Borden 2011-08-20 21:18:33 UTC 
Comment on attachment 192222 [details] [review]
Fixes the string.

Commited as 6ad6f26f1ed331a792de7741b512f7d5d0436198

This will be included in Tomboy 1.7.4

Thanks for reporting!