After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654749 - goom: unbreak build on PPC on openbsd
goom: unbreak build on PPC on openbsd
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.30
Other OpenBSD
: Normal normal
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-07-16 18:37 UTC by Antoine Jacoutot
Modified: 2011-07-16 22:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add missing include (649 bytes, patch)
2011-07-16 18:37 UTC, Antoine Jacoutot 		none Details | Review

Description Antoine Jacoutot 2011-07-16 18:37:31 UTC 
Created attachment 192095 [details] [review]
add missing include

Hi.

Under OpenBSD building gst-plugins-good fails with the following error:

/usr/include/sys/proc.h:64: error: 'MAXLOGNAME' undeclared here (not in a function)
/usr/include/sys/proc.h:285: error: 'MAXCOMLEN' undeclared here (not in a function)

This patch adds a missing include for sys/param.h which fixes the build for me. I don't know whether Linux has the same issue but I don't think adding this include should have any bad effect in case it already builds correctly there.
Comment 1 Tim-Philipp Müller 2011-07-16 19:08:27 UTC 
Thanks for the patch. I was wondering: what happens if you just remove these two includes:

#include <sys/types.h>
#include <sys/sysctl.h>

I don't see what they'd be needed for.
Comment 2 Antoine Jacoutot 2011-07-16 22:38:35 UTC 
(In reply to comment #1)
> Thanks for the patch. I was wondering: what happens if you just remove these
> two includes:
> 
> #include <sys/types.h>
> #include <sys/sysctl.h>
> 
> I don't see what they'd be needed for.

Indeed, it works fine without them.
Comment 3 Tim-Philipp Müller 2011-07-16 22:52:08 UTC 
Great, thanks!

 commit df3cee6606bed13d2edc8480ed244d480ab4790c
 Author: Antoine Jacoutot <ajacoutot@openbsd.org>
 Date:   Sat Jul 16 23:47:50 2011 +0100

    goom: fix build on PPC on openbsd
    
    A missing sys/param.h include results in:
    
    /usr/include/sys/proc.h:64: error: 'MAXLOGNAME' undeclared here (not in a
    function)
    /usr/include/sys/proc.h:285: error: 'MAXCOMLEN' undeclared here (not in a
    function)
    
    when compiling goom on openbsd/ppc. We can just remove the two sys/ includes
    here, they are not needed for anything.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=654749