After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654744 - matroskademux: fix aspect ratio if header has only onle display variable set
matroskademux: fix aspect ratio if header has only onle display variable set
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal major
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-07-16 17:44 UTC by Oleksij Rempel
Modified: 2011-07-16 23:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch v1 (1.65 KB, patch)
2011-07-16 17:45 UTC, Oleksij Rempel 		committed Details | Review

Description Oleksij Rempel 2011-07-16 17:44:54 UTC 
Current matrosca demuxe calculate aspectratio only if both, DisplayHeight and
DisplayWidth are set.
But it is legal to use only one variable if second is equal to PixelWidth or
PixelHeight. At least mkclean doint that.

So this make mkcleaned files plays correct.
Comment 1 Oleksij Rempel 2011-07-16 17:45:57 UTC 
Created attachment 192092 [details] [review]
patch v1
Comment 2 Tim-Philipp Müller 2011-07-16 23:16:58 UTC 
Thanks for the patch:

commit 69c14012c9585780a9fd69c73f80d13f7917432d
Author: Alexey Fisher <bug-track@fisher-privat.net>
Date:   Sat Jul 16 19:38:51 2011 +0200

    matroskademux: fix pixel-aspect-ratio if header has only one display variable
    
    Current matroska demux calculates the pixel aspect ratio only if both
    DisplayHeight and DisplayWidth are set, but it is legal to use only
    one variable if the other is equal to PixelWidth or PixelHeight, at
    least the mkclean utility is doing that. So this makse mkcleaned
    files play correctly.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=654744