After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654695 - Memory corruption in gtk_theming_engine_register_property()
Memory corruption in gtk_theming_engine_register_property()
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-07-15 18:50 UTC by Florian Müllner
Modified: 2011-07-15 21:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
theming-engine: Adjust register_property() to recent glib change (1.11 KB, patch)
2011-07-15 18:50 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2011-07-15 18:50:25 UTC 
As of commit d6c30e1766c975[0], GParamSpec uses interned strings for the name, which breaks the mess-with-param-spec's-internals-to-add-a-namespace hack in the mentioned function.
The attached patch uses g_intern_string for the replacement as well, which should fix the issue.

[0] http://git.gnome.org/browse/glib/commit?id=d6c30e1766c975
Comment 1 Florian Müllner 2011-07-15 18:50:28 UTC 
Created attachment 192053 [details] [review]
theming-engine: Adjust register_property() to recent glib change

GParamSpec now uses an intern'ed string for 'name', so the code
in gtk_theming_engine_register_property() which prefixes the name
with a namespace has to be adjusted.
Comment 2 Matthias Clasen 2011-07-15 21:24:20 UTC 
Review of attachment 192053 [details] [review]:

ugh, pretty bad hack. But if this patch makes it limp along, please commit.
Comment 3 Florian Müllner 2011-07-15 21:26:54 UTC 
Attachment 192053 [details] pushed as 7741f5a - theming-engine: Adjust register_property() to recent glib change