Created attachment 191935 [details] [review]
fixes rtpmp4gdepay

Could you resubmit the patch in 'git format-patch' format?  It makes it easier to review and automatically carries the submitter and changelog information.

"latest gstreamer release" -- is this a regression?

This bug didn't occur before 2008/9/15 when the interleaved AU supported was added.

Created attachment 192014 [details] [review]
patch

Comment on attachment 192014 [details] [review]
patch

>@@ -611,6 +611,8 @@ gst_rtp_mp4g_depay_process (GstBaseRTPDepayload * depayload, GstBuffer * buf)
>               rtpmp4gdepay->next_AU_index = GST_BUFFER_OFFSET (outbuf);
>               gst_rtp_mp4g_depay_flush_queue (rtpmp4gdepay);
>             }
>+            // rebase next_AU_index to current rtp's first AU_index
>+            rtpmp4gdepay->next_AU_index = AU_index;
>           }
>           rtpmp4gdepay->prev_rtptime = rtptime;
>           rtpmp4gdepay->prev_AU_num = num_AU_headers;

Without knowing the details of the code, it looks to me like one of these two rtpmp4gdepay->next_AU_index assignments is either wrong or superfluous (why assign it to A if it's going to be assigned to B two lines below?). Also, please don't use C++-style comments, use /* blah */ -style comments

Thanks.  Turned it into a commit this way.

W.r.t. to the assignments as marked above, there is some stuff happening in the function call (gst_rtp_mp4g_depay_flush_queue) that 'interacts' with the assignments.

commit 06f8e356a6829e067e81e8c2bf7bac334304a44b
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Tue Sep 6 13:18:40 2011 +0200

    rtpmp4gdepay: improve bogus interleaved index compensating
    
    Patch by <gudake@gmail.com>
    
    Fixes #654585.

Hm, obviously missed the second attachment here :(