GNOME Bugzilla – Bug 654583
Immediate RTCP in rtpsession
Last modified: 2011-07-25 15:23:35 UTC
RFC 4585 describes 3 modes for sending RTCP: Regular, Early and Immediate. We currently implement the first two, the attached patches implement the 3rd. In immediate mode, RTCP feedback is sent immediately at the application's request in addition to regular RTCP packets.
Created attachment 191933 [details] [review] rtpsession: Don't let the computed RTP bandwidth fall too low If it falls too low, the computer RTCP bandwidth will be near zero and the RTCP thread will be stopped.
Created attachment 191934 [details] [review] rtpsession: Always send application requested feedback in immediate mode Send as many application requested feedback messages in immediate mode, even if they have already been sent.
Review of attachment 191933 [details] [review]: Typo in the commit message.
Created attachment 191998 [details] [review] rtpsession: Don't let the computed RTP bandwidth fall too low If it falls too low, the computed RTCP bandwidth will be near zero and the RTCP thread will be stopped.
Comment on attachment 191933 [details] [review] rtpsession: Don't let the computed RTP bandwidth fall too low Ooops, updated the patch
(In reply to comment #2) > Created an attachment (id=191934) [details] [review] > rtpsession: Always send application requested feedback in immediate mode > > Send as many application requested feedback messages in immediate mode, even if > they > have already been sent. > - /* RFC 4585 section 3.5.2 step 4 */ > - if (sess->allow_early == FALSE) > + /* RFC 4585 section 3.5.2 step 4 > + * But allow feedback anyway if we are below the immediate feedback threshold > + */ > + if (sess->total_sources < sess->rtcp_immediate_feedback_threshold || > + sess->allow_early == FALSE) > goto dont_send; Seems odd here; the intention is apparently to allow feedback/sending if below threshold, but the code path will go to dont_send (which does not sound promising ...) There is also a stray empty line added somewhere, and the default value for the new property is not set in _init (afaics).
Committed other patch: commit 354faabda02f84d68ae24fe3d96242e8a242f456 Author: Olivier Crête <olivier.crete@collabora.com> Date: Wed Jun 8 14:48:01 2011 -0400 rtpsession: Don't let the computed RTP bandwidth fall too low If it falls too low, the computed RTCP bandwidth will be near zero and the RTCP thread will be stopped. https://bugzilla.gnome.org/show_bug.cgi?id=654583
Created attachment 192619 [details] [review] rtpsession: Always send application requested feedback in immediate mode Thanks for the feedback, patch updated.
Thanks. commit 6095d2a3f00e1cb14736648fed42751b5f8a7832 Author: Olivier Crête <olivier.crete@collabora.com> Date: Wed Jun 8 15:57:37 2011 -0400 rtpsession: Always send application requested feedback in immediate mode Send as many application requested feedback messages in immediate mode, even if they have already been sent. https://bugzilla.gnome.org/show_bug.cgi?id=654583