After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654536 - GSettings: lift key name length restriction to 64
GSettings: lift key name length restriction to 64
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gsettings
unspecified
Other All
: Normal normal
: ---
Assigned To: Allison Karlitskaya (desrt)
gtkdev
Depends on:
Blocks:
 
 
Reported: 2011-07-13 09:52 UTC by Allison Karlitskaya (desrt)
Modified: 2011-07-19 14:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GSettings: lift key name length restriction to 64 (1.63 KB, patch)
2011-07-13 09:52 UTC, Allison Karlitskaya (desrt)
none Details | Review

Description Allison Karlitskaya (desrt) 2011-07-13 09:52:40 UTC
I forget why we introduced the restriction for key names to be 32
characters, but it is now causing problems.

I checked, and it's not because of restrictions of the Windows registry.
dconf is also well-capable of handling much longer key names (up to
65535 chars, I think).
Comment 1 Allison Karlitskaya (desrt) 2011-07-13 09:52:42 UTC
Created attachment 191868 [details] [review]
GSettings: lift key name length restriction to 64

The previous limit was 32.

The compiz port to GSettings is hitting its head up against this
restriction since many of its plugins were already using longer key
names.
Comment 2 Matthias Clasen 2011-07-13 11:39:13 UTC
I don't understand this. You seem to argue that there is no need to have any small length restrictions, but your patch does not remove the restriction.
Comment 3 Allison Karlitskaya (desrt) 2011-07-13 23:07:58 UTC
It increases the limit to 64.

We can't remove length limitations entirely.  We could, however, increase them to something truly obscene (like the 65535-byte limit I mention from dconf).
Comment 4 Matthias Clasen 2011-07-14 03:21:28 UTC
64k is pretty close to 'no limit', in practice. Even 1k would be big enough to pass for 'unlimited' for key lengths. Anything below 100 most certainly is still a real limit that people will actually hit.
Comment 5 Allison Karlitskaya (desrt) 2011-07-19 14:19:24 UTC
Okay.  1k it is.

commit fe6dad271b06e6243d17137c2e0991f56a256cca
Author: Ryan Lortie <desrt@desrt.ca>
Date:   Tue Jul 19 16:12:30 2011 +0200

    GSettings: remove key length restrictions
    
    The key length now stands effectively unlimited at 1024 characters.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=654536